Summary: | media-sound/mixxx-9999: CMAKE_BUILD_TYPE=Gentoo is not supported, use one of Debug, Release or RelWithDebInfo. | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | gerion <gerion.entrup> |
Component: | Current packages | Assignee: | Professional Audio Applications Maintainers <proaudio> |
Status: | RESOLVED OBSOLETE | ||
Severity: | normal | CC: | fordfrog, kripton |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | 780888 | ||
Bug Blocks: | |||
Attachments: | build.log |
Description
gerion
2021-06-20 23:49:01 UTC
Created attachment 717258 [details]
build.log
Upstream commit: https://github.com/mixxxdj/mixxx/commit/c7aa1c9a984ebb4dfdd81bc0e0b630602d080221 "Fail with CMAKE_BUILD_TYPE=MinSizeRel or any other unsupported value" CMAKE_BUILD_TYPE=Gentoo is automatically set by cmake.eclass Maybe we should set CMAKE_BUILD_TYPE to one of Debug, Release (or RelWithDebInfo ?) in the ebuild. We should ignore upstream's wishes. If I revert the upstream commit c7aa1c9a984ebb4dfdd81bc0e0b630602d080221 all seems to work normal in media-sound/mixxx-2.3.9999. But I still see too: * Hardcoded definition(s) removed in CMakeLists.txt: * set(CMAKE_BUILD_TYPE "${default_build_type}" CACHE STRING "Choose the type Can we solve the bugs with the live ebuilds and then bump to https://github.com/mixxxdj/mixxx/releases/tag/2.3.0 ? sure, but first i'd like to see the docs issue resolved. I found a discussion about CMAKE_BUILD_TYPE in archlinux with the mixxx-developers: https://github.com/archlinux/svntogit-community/commit/da37cf256156dead98e5a62219ab4006167986f9#r53047679 I have packaged mixxx with the two updated patches in my overlay: https://gitweb.gentoo.org/repo/user/gerislay.git/tree/media-sound/mixxx The current mixxx-9999 version depends on hidapi-0.10.1, see https://bugs.gentoo.org/696482. It can be installed from the netfab overlay (https://github.com/netfab/overlay) Upstream PR for allowing buildtype "None" used in Alpine Linux https://github.com/mixxxdj/mixxx/pull/4112 https://github.com/gentoo/gentoo/pull/22497 contains a patch that adds buildtype "Gentoo" https://gitweb.gentoo.org/repo/user/gerislay.git/tree/media-sound/mixxx/files/mixxx-9999-gentoo-build.patch removes the FATAL_ERROR message. Which way do we wanna go? Although I wrote one of the patches, I have no strong opinion. I chose this approach this it seems minimal invasive and seems to work (at least the latest Mixxx is running for me again). BTW, I had a problem with an unwanted dev-cpp/benchmark dependency, this is solved in a quick and dirty way in my ebuild https://gitweb.gentoo.org/repo/user/gerislay.git/tree/media-sound/mixxx/files/drop-mixxx-test.patch Please find a better way :). (In reply to gerion from comment #10) > Although I wrote one of the patches, I have no strong opinion. I chose this > approach this it seems minimal invasive and seems to work (at least the > latest Mixxx is running for me again). > > BTW, I had a problem with an unwanted dev-cpp/benchmark dependency, this is > solved in a quick and dirty way in my ebuild > https://gitweb.gentoo.org/repo/user/gerislay.git/tree/media-sound/mixxx/ > files/drop-mixxx-test.patch > Please find a better way :). Bug 822357 gerion, your https://gitweb.gentoo.org/repo/user/gerislay.git/tree/media-sound/mixxx/mixxx-9999.ebuild is missing commit https://github.com/gentoo/gentoo/commit/7a8c9e7be5c18dde7265591309bad5fe026957ca "add missing slot operator dep (libid3tag)" and Bug 775443 - media-sound/mixxx-{2.3.9999,9999}: upstream has changed from libshout to libshout-idjc Ported to EAPI-8 in commit 5acda659d06d385c84365844e2bde568819a9e0b, cmake.eclass in EAPI-8 defaults to RelWithDebInfo. |