| Summary: | media-libs/mlt-7.0.1 version bump (switch to cmake) | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Sven Eden <sven.eden> |
| Component: | Current packages | Assignee: | Gentoo Media-video project <media-video> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kde, sam |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://invent.kde.org/multimedia/kdenlive/-/merge_requests/207 | ||
| See Also: | https://bugs.gentoo.org/show_bug.cgi?id=603168 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 796560 | ||
| Attachments: |
Experimental ebuild to install mlt-7.0.1
Fix man page symlinking in new cmake build system Remove absolute runtime paths from new cmake build system |
||
Created attachment 716688 [details, diff]
Fix man page symlinking in new cmake build system
The build system was changed to cmake, and not everything is fully in order there, yet. The unpatched CMakeLists.txt uses absolute paths for symlinking the man page, which triggers a sandbox violation.
Created attachment 716691 [details, diff]
Remove absolute runtime paths from new cmake build system
The unpatched CMakeLists.txt does not remove the absolute runtime paths upon installation, causing Q/A warnings about unsafe paths on merging.
Also blocking kdenlive-21.08 release. Sven, you didn't include the Signed-off-by line. Could you inclulde that if you agree to the GCO terms and also ideally provide it via `git format-patch`? (Note I think you forgot to CC kde@ as co-maintainers by the way.) I'll need to do this myself otherwise. Is a separate slot/parallel installation feasible at all? Otherwise, we'll just restrict kdenlive-21.04.3 to mlt-6 before stabilisation, and soon-to-be-released 21.08.0 will support >=mlt-7 anyway. (In reply to Andreas Sturmlechner from comment #5) > Is a separate slot/parallel installation feasible at all? I started poking at this but didn't really have enough time in the end. I figured it wasn't worth the hassle. > Otherwise, we'll just restrict kdenlive-21.04.3 to mlt-6 before stabilisation, and > soon-to-be-released 21.08.0 will support >=mlt-7 anyway. I'll do this in the same push later today hopefully. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=22a5116e66ece33b10989f419953f138a0564620 commit 22a5116e66ece33b10989f419953f138a0564620 Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2021-08-01 19:41:40 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2021-08-01 20:19:11 +0000 kde-apps/kdenlive: Restrict to <media-libs/mlt-7 Bug: https://bugs.gentoo.org/796557 Package-Manager: Portage-3.0.20, Repoman-3.0.3 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> .../kdenlive/{kdenlive-21.04.3.ebuild => kdenlive-21.04.3-r1.ebuild} | 1 + 1 file changed, 1 insertion(+) The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b87e752f3025f4010a3b52f74297cbc063316479 commit b87e752f3025f4010a3b52f74297cbc063316479 Author: Sam James <sam@gentoo.org> AuthorDate: 2021-07-22 05:14:32 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2021-08-05 01:47:44 +0000 media-libs/mlt: add 7.0.1 Closes: https://bugs.gentoo.org/796557 Signed-off-by: Sam James <sam@gentoo.org> media-libs/mlt/Manifest | 1 + media-libs/mlt/files/mlt-7.0.1-cmake-symlink.patch | 14 ++ media-libs/mlt/mlt-7.0.1.ebuild | 209 +++++++++++++++++++++ 3 files changed, 224 insertions(+) (In reply to Sam James from comment #4) > Sven, you didn't include the Signed-off-by line. Could you inclulde that if > you agree to the GCO terms and also ideally provide it via `git > format-patch`? > > (Note I think you forgot to CC kde@ as co-maintainers by the way.) > > I'll need to do this myself otherwise. Oh? That one went past me. Where did I forget to use --signoff? I normally use that always and everywhere... :-( Sam, aren't we missing sci-libs/fftw:3.0= unconditional dep now that MOD_PLUS is left default enabled by the build system? (In reply to Andreas Sturmlechner from comment #10) > Sam, aren't we missing sci-libs/fftw:3.0= unconditional dep now that > MOD_PLUS is left default enabled by the build system? IIRC I'd thought it was off but apparently there's a use for FFTW as Eric pointed out. Will look at it (and check the others) later. Away at moment (at vet again...) The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0a92d5b2e4cee52fa9a8df28e1b4fdd4f0195cc8 commit 0a92d5b2e4cee52fa9a8df28e1b4fdd4f0195cc8 Author: Sam James <sam@gentoo.org> AuthorDate: 2021-12-02 23:37:13 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2021-12-02 23:38:10 +0000 media-libs/mlt: unconditionally enable FFTW (PLUS) Closes: https://bugs.gentoo.org/603168 Closes: https://bugs.gentoo.org/796557 Signed-off-by: Sam James <sam@gentoo.org> media-libs/mlt/{mlt-7.2.0.ebuild => mlt-7.2.0-r1.ebuild} | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) |
Created attachment 716685 [details] Experimental ebuild to install mlt-7.0.1 media-video/shotcut newer than Version 21.03.21 has switched to mlt-7. Attached is an experimental ebuild for media-libs/mlt-7.0.1, which WILL *BREAK* kdenlive(*)! It is only meant as a starting point. The new mlt-7 has its binaries and libraries re-organized, so my ebuild might only be a starting point to get mlt slotted? (*) kdenlive calls objects and functions that are no longer present, so it is not about a simple patching. As I am using shotcut, I have added kde-apps/kdenlive to package.provided and am happy, but having mlt to be slotted, so both can be installed, might be the more reasonable approach.