Bug 795522 – net-misc/ntpsec-1.2.1-r2 does not enable tests

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Agostino Sarubbo 2021-06-12 08:38:45 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-misc/ntpsec-1.2.1 does not enable tests.
Discovered on: amd64 (internal ref: ci)

NOTE:
This machine uses GCC-11: https://gcc.gnu.org/gcc-11/porting_to.html

[Comment 1 Agostino Sarubbo 2021-06-12 08:38:48 UTC]

Created attachment 715458 [details]
build.log

build log and emerge --info

[Comment 2 James Browning 2021-06-13 22:25:05 UTC]

Huh, I think the tests do run, just not in the 'test' phase. relevant output between lines
"execution summary" and "'build' finished successfully (28.583s)".

Making a patch to have them also run in 'test' phase would be easier without the bozo bit. probably inject the following after replacing the "\t" with something appropriate.

src_test() {
\t"${S}"/waf check
}

[Comment 3 James Browning 2021-07-01 15:42:54 UTC]

Created attachment 720822 [details, diff]
proposed patch to make ntpsec have seperate and verbose test phase

Signed-off-by: James Browning <[e-mail]>

[Comment 4 Sam James 2021-07-01 20:36:59 UTC]

Possible to stop it running in _compile?

[Comment 5 James Browning 2021-07-01 21:54:26 UTC]

Created attachment 720849 [details, diff]
proposed patch to make ntpsec only run tests in test phase

I do not think this is a very good idea.

Signed-off-by: James Browning <[e-mail]>

[Comment 6 Agostino Sarubbo 2021-11-14 14:08:03 UTC]

ci has reproduced this issue with version 1.2.1-r1 - Updating summary.

[Comment 7 Agostino Sarubbo 2022-04-07 06:31:19 UTC]

ci has reproduced this issue with version 1.2.1-r2 - Updating summary.

[Comment 8 Larry the Git Cow 2022-04-20 01:03:07 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=37c2b340b2370499d0e6230e4f8b50d079a7d096

commit 37c2b340b2370499d0e6230e4f8b50d079a7d096
Author:     James Browning <[e-mail]>
AuthorDate: 2022-04-12 11:52:09 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2022-04-20 01:02:58 +0000

    net-misc/ntpsec: Try to only run tests in src_test only
    
    Since ./waf test runs all the test, this eliminates the need for
    the tests useflag which filled that space. Thus it's eliminated.
    
    Bug: https://bugs.gentoo.org/795522
    Closes: https://bugs.gentoo.org/838109
    Signed-off-by: James T Browning <[e-mail]>
    Signed-off-by: Sam James <[e-mail]>

 .../ntpsec/files/ntpsec-1.2.1-build-notests.patch  |  48 ++++++
 .../ntpsec/files/ntpsec-py3-test-clarify.patch     |  34 ++++
 net-misc/ntpsec/ntpsec-1.2.1-r3.ebuild             | 177 +++++++++++++++++++++
 net-misc/ntpsec/ntpsec-9999.ebuild                 |  17 +-
 4 files changed, 272 insertions(+), 4 deletions(-)

[Comment 9 Larry the Git Cow 2022-04-20 01:11:39 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=acd71bea7fbacb805d42a738f8c03de747fd2917

commit acd71bea7fbacb805d42a738f8c03de747fd2917
Author:     Sam James <[e-mail]>
AuthorDate: 2022-04-20 01:09:06 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2022-04-20 01:09:06 +0000

    net-misc/ntpsec: silence wrong warning about tests
    
    We are running them.
    
    Closes: https://bugs.gentoo.org/795522
    Signed-off-by: Sam James <[e-mail]>

 net-misc/ntpsec/ntpsec-1.2.1-r3.ebuild | 5 +++++
 net-misc/ntpsec/ntpsec-9999.ebuild     | 6 +++++-
 2 files changed, 10 insertions(+), 1 deletion(-)

[Comment 10 Sam James 2022-04-20 01:12:19 UTC]

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=37c2b340b2370499d0e6230e4f8b50d079a7d096

commit 37c2b340b2370499d0e6230e4f8b50d079a7d096
Author:     James Browning <[e-mail]>
AuthorDate: 2022-04-12 11:52:09 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2022-04-20 01:02:58 +0000

    net-misc/ntpsec: Try to only run tests in src_test only
    
    Since ./waf test runs all the test, this eliminates the need for
    the tests useflag which filled that space. Thus it's eliminated.
    
    Bug: https://bugs.gentoo.org/795522
    Closes: https://bugs.gentoo.org/838109
    Signed-off-by: James T Browning <[e-mail]>
    Signed-off-by: Sam James <[e-mail]>

 .../ntpsec/files/ntpsec-1.2.1-build-notests.patch  |  48 ++++++
 .../ntpsec/files/ntpsec-py3-test-clarify.patch     |  34 ++++
 net-misc/ntpsec/ntpsec-1.2.1-r3.ebuild             | 177 +++++++++++++++++++++
 net-misc/ntpsec/ntpsec-9999.ebuild                 |  17 +-
 4 files changed, 272 insertions(+), 4 deletions(-)