Summary: | net-im/telegram-desktop-2.7.4-r1: notifications_manager_default.cpp.o: in function `doSkipAudio() const': notifications_manager_default.cpp:(.text+0x61): undefined reference to `Platform::Notifications::SkipAudioForCustom()' | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Joe Kappus <joe> |
Component: | Current packages | Assignee: | Esteve Varela Colominas <esteve.varela> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | proxy-maint, waebbl-gentoo |
Priority: | Normal | Keywords: | PullRequest |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://github.com/gentoo/gentoo/pull/21118 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | build.log |
Description
Joe Kappus
2021-06-04 04:03:15 UTC
I'll look at this properly later, but inmediately I notice a custom patch is being applied. Can you reproduce this without that patch? Nevermind, I've reproduced this with your USE flag combination. https://github.com/telegramdesktop/tdesktop/commit/404538c98968d44d207671de3adde91b8df50721 Fix was already upstream, applying locally... Lovely how USE=-dbus seems to keep breaking every single update. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c612239cd9c08b694ba8542b288610c92c3e870a commit c612239cd9c08b694ba8542b288610c92c3e870a Author: Esteve Varela Colominas <esteve.varela@gmail.com> AuthorDate: 2021-06-04 12:45:41 +0000 Commit: Georgy Yakovlev <gyakovlev@gentoo.org> CommitDate: 2021-06-04 18:43:34 +0000 net-im/telegram-desktop: Fix USE=-dbus No revbump since it wasn't able to build, and this has no single chance of affecting anything *but* USE=-dbus. Closes: https://bugs.gentoo.org/794094 Thanks-to: Joe Kappus <joecool1029@gmail.com> Signed-off-by: Esteve Varela Colominas <esteve.varela@gmail.com> Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org> ...desktop-2.7.4-fix-disable-dbus-integration.patch | 21 +++++++++++++++++++++ .../telegram-desktop-2.7.4-r1.ebuild | 3 ++- 2 files changed, 23 insertions(+), 1 deletion(-) It's one of those "community maintained" features that is never tested in upstream builds. If it keeps breaking I think it will be reasonable to remove this flag from ebuild completely, as it's kinda hard to actually build rest of the system without dbus due to big chunk of dependencies pulling it unconditionally. For some reason I thought it was part of their CI matrix, but I guess it's not. Oh well, currently it's still possible to use Telegram without D-Bus, and there's enough people interested given we get bug reports for it and it tends to be fixed upstream before we notice, so I see no reason to remove it. Might want to test it more often, however... |