Summary: | dev-qt/qtcore-5.15.2-r2 - configure: line 799: make LIBTOOL=rdlibtool: command not found | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Toralf Förster <toralf> |
Component: | Current packages | Assignee: | Qt Bug Alias <qt> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | asturm, orbea, sam |
Priority: | Normal | Keywords: | PullRequest |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://github.com/gentoo/gentoo/pull/26453 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 765709 | ||
Attachments: |
emerge-info.txt
dev-qt:qtcore-5.15.2-r2:20210529-111925.log emerge-history.txt environment etc.portage.tar.bz2 logs.tar.bz2 temp.tar.bz2 |
Description
Toralf Förster
2021-05-29 11:56:05 UTC
Created attachment 712182 [details]
emerge-info.txt
Created attachment 712185 [details]
dev-qt:qtcore-5.15.2-r2:20210529-111925.log
Created attachment 712188 [details]
emerge-history.txt
Created attachment 712191 [details]
environment
Created attachment 712194 [details]
etc.portage.tar.bz2
Created attachment 712197 [details]
logs.tar.bz2
Created attachment 712200 [details]
temp.tar.bz2
ok, related to IRC: [4:17:48 pm] <+sam_> are you setting MAKE="make libtool="? [4:17:57 pm] <+toralf> yes : https://github.com/toralf/tinderbox/blob/master/bin/setup_img.sh#L331 [4:18:12 pm] <+sam_> don't do that I think [4:18:16 pm] <+toralf> got that from a wiki page [4:18:17 pm] <+sam_> just the other two [4:18:33 pm] <+toralf> ok, removed [4:18:40 pm] <+sam_> https://wiki.gentoo.org/wiki/Slibtool#Usage this mentions it indeed [4:18:45 pm] <+sam_> but drop it for now i think I can mark this as invalid ? Not sure. The "problem" is that $MAKE is quoted in the configure... (cd "$outpath/qmake"; "$MAKE") || exit 2 probably to guard against someone setting MAKE="<path with spaces>". So the shell tries to execute "make LIBTOOL=rdlibtool" as if it was the name of a command, which obviously doesn't exist. I don't think it's expected to have options/variables in the value of $MAKE (that's what MAKEFLAGS is for), but please correct me if I'm wrong. Note however that we patch that line to include MAKEOPTS and EXTRA_EMAKE, as customary in gentoo. So, why don't you use EXTRA_EMAKE="LIBTOOL=rdlibtool" and leave MAKE alone? Generally slibtool is set with: MAKEFLAGS='LIBTOOL=rlibtool' But some build systems use recursive make where the MAKEFLAGS env gets lost and this is where setting MAKE is required: MAKE='make LIBTOOL=libtool' Adding arguments to the make(1) command is not quite the same thing, the MAKE variable is used by the build system itself. The issue here is quoting "$MAKE" and the fix would be to remove the quotes. Aren't you really saying that we should patch configure to add MAKEFLAGS as well? Ah I see. I suppose it shouldn't hurt to drop the quoting for our usage... The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c4859473944244496cbd0b28f5fb525a4a930e4b commit c4859473944244496cbd0b28f5fb525a4a930e4b Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2022-07-17 15:57:54 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2022-07-23 11:21:01 +0000 dev-qt/qtcore: Fix configure w/ slibtool Closes: https://bugs.gentoo.org/792804 Package-Manager: Portage-3.0.32, Repoman-3.0.3 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> dev-qt/qtcore/files/qtcore-5.15.5-slibtool.patch | 29 ++++++++++++++++++++++++ dev-qt/qtcore/qtcore-5.15.5-r2.ebuild | 2 ++ 2 files changed, 31 insertions(+) Additionally, it has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3834431f616e7cd362315b23ea47e2aade67a264 commit 3834431f616e7cd362315b23ea47e2aade67a264 Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2022-07-17 15:39:40 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2022-07-23 11:21:01 +0000 qt5-build.eclass: Support sed regardless if $MAKE is quoted or not Bug: https://bugs.gentoo.org/792804 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> eclass/qt5-build.eclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/qt.git/commit/?id=aa7f8e5bd7efbba10385ac768a817f0675daded1 commit aa7f8e5bd7efbba10385ac768a817f0675daded1 Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2022-07-17 15:39:40 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2022-07-23 11:23:35 +0000 qt5-build.eclass: Support sed regardless if $MAKE is quoted or not Bug: https://bugs.gentoo.org/792804 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> eclass/qt5-build.eclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) |