| Summary: | gui-libs/gtk-4.2.1: Install fails because of outdated mv command in install | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Bernd Feige <Bernd.Feige> |
| Component: | Current packages | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | adel.ks, atoth, fedora.dm0, gentoo, harrisl, jstein, marduk, nickAristocrates, sam, steffen.weber |
| Priority: | Normal | Keywords: | PATCH |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | fix.patch | ||
> The whole src_install() function can be removed because the build was fixed upstream to install to /usr/share/doc/gtk-4.2.1/ instead of gtk4.
Can you show me where that happened? I looked in git and didn't see it.
(In reply to Matt Turner from comment #1) > > The whole src_install() function can be removed because the build was fixed upstream to install to /usr/share/doc/gtk-4.2.1/ instead of gtk4. > > Can you show me where that happened? I looked in git and didn't see it. Is this commit that you probably have missed? https://gitlab.gnome.org/GNOME/gtk/-/commit/642f32e14d507df5282197afc78efb6405cfe9c2#33e3f16a2e94c672e89c47874c4eb2dcd70f1bf1) Same problem appears on gui-libs/gtk-4.2.0, too. (In reply to myloveyuxuan from comment #2) > (In reply to Matt Turner from comment #1) > > > The whole src_install() function can be removed because the build was fixed upstream to install to /usr/share/doc/gtk-4.2.1/ instead of gtk4. > > > > Can you show me where that happened? I looked in git and didn't see it. > > Is this commit that you probably have missed? > https://gitlab.gnome.org/GNOME/gtk/-/commit/ > 642f32e14d507df5282197afc78efb6405cfe9c2#33e3f16a2e94c672e89c47874c4eb2dcd70f > 1bf1) Sorry, I don't think so as this occurs with -gtk-doc - /usr/share/doc/gtk-4.2.1 is, as far as I can see, simply the default created by einstalldocs (/usr/portage/eclass/eutils.eclass). Something was previously installed under "/usr/share/doc/gtk4" that needed to be patched up but not any longer. Could it be related to the recent app-portage/portage-utils-0.91 upgrade? *** Bug 788160 has been marked as a duplicate of this bug. *** Created attachment 705996 [details, diff]
fix.patch
This fixed it for me.
*** Bug 788166 has been marked as a duplicate of this bug. *** Three other directories are being installed:
/usr/share/doc/gdk4
/usr/share/doc/gdk4-wayland
/usr/share/doc/gsk4
Also ${PF} instead of ${P}.
My preference would be as per econf --htmldir
/usr/share/doc/${PF}/html/
gdk4
gdk4-wayland
gsk4
gtk4
Automatically excluded from docompress (which looks relevant for the bundled fonts logo and search index) etc.
Suggest, instead of src_install():
src_prepare() {
default
sed -i "s:gtk_datadir / 'doc':gtk_datadir / 'doc/${PF}/html':" docs/reference/meson.build || die
}
I think Matt is on it. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=29744120a6b62882342edc5400bf8b17600e52ed commit 29744120a6b62882342edc5400bf8b17600e52ed Author: Matt Turner <mattst88@gentoo.org> AuthorDate: 2021-05-04 14:35:53 +0000 Commit: Matt Turner <mattst88@gentoo.org> CommitDate: 2021-05-04 20:12:16 +0000 gui-libs/gtk: Install docs to html/ Suggested by Chris Mayo to avoid compressing included SVGs and fonts. Thanks for David Michael for the initial patch. Closes: https://bugs.gentoo.org/788082 Signed-off-by: Matt Turner <mattst88@gentoo.org> gui-libs/gtk/gtk-4.2.1.ebuild | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) |
The ebuild contains: src_install() { meson_src_install mv "${ED}"/usr/share/doc/{gtk4,${P}} || die } This leads to the install error "mv: cannot stat '/var/tmp/portage/gui-libs/gtk-4.2.1/image/usr/share/doc/gtk4': No such file or directory" The whole src_install() function can be removed because the build was fixed upstream to install to /usr/share/doc/gtk-4.2.1/ instead of gtk4. Reproducible: Always