| Summary: | net-libs/libwebsockets: Please clean dependencies after removing libressl support | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | DC <gtbgs> |
| Component: | Current packages | Assignee: | Jaco Kroon <jaco> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | jaco, jsmolic, luka.perkov, phantom4, proxy-maint, sam |
| Priority: | Normal | Keywords: | PullRequest |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://github.com/gentoo/gentoo/pull/20486 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
Yes, USE=ssl should be "do I want SSL?" and we'll default to OpenSSL. The first REQUIRED_USE clause can go, no other changes needed. *** Bug 788106 has been marked as a duplicate of this bug. *** The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=467bffc308bf969f4d4ba54f27069db0609a5daf commit 467bffc308bf969f4d4ba54f27069db0609a5daf Author: Sam James <sam@gentoo.org> AuthorDate: 2021-05-04 03:42:45 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2021-05-04 19:09:54 +0000 net-libs/libwebsockets: simplify REQUIRED_USE after LibreSSL removal Closes: https://bugs.gentoo.org/788079 Signed-off-by: Sam James <sam@gentoo.org> net-libs/libwebsockets/libwebsockets-4.1.6.ebuild | 1 - 1 file changed, 1 deletion(-) |
Hi, you recently removed libressl from net-libs/libwebsockets-4.1.6.ebuild, leaving the file as: REQUIRED_USE=" ssl? ( mbedtls ) mbedtls? ( ssl ) " RDEPEND=" ssl? ( !mbedtls? ( dev-libs/openssl:0= ) mbedtls? ( >net-libs/mbedtls-2.0.0 ) ) " It seems a bit circular to have `ssl` and `mbedtls` require each other in REQUIRED_USE. Could you get away with a single USE flag if that's what you intended? Also, does the RDEPEND clause still make sense anymore? It doesn't seem possible to select `ssl` without `mbedtls` after your change.