| Summary: | dev-libs/isl-0.23-r1: configure errors when /bin/sh != bash | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Matt Whitlock <gentoo> |
| Component: | Current packages | Assignee: | Gentoo Toolchain Maintainers <toolchain> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | sam |
| Priority: | Normal | Keywords: | PATCH |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://groups.google.com/g/isl-development/c/GOmQqKVDpRk | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 526268 | ||
| Attachments: | isl-0.23-fix-configure-bashisms.patch | ||
Note that such a fix would therefore ideally be accompanied with a revbump. Can you send the patch upstream as well? Should be a matter of sending patch to https://groups.google.com/g/isl-development The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=611d3746e7445cf612bb4a623ebdff15879afc9d commit 611d3746e7445cf612bb4a623ebdff15879afc9d Author: Sergei Trofimovich <slyfox@gentoo.org> AuthorDate: 2021-05-02 21:31:09 +0000 Commit: Sergei Trofimovich <slyfox@gentoo.org> CommitDate: 2021-05-02 21:31:19 +0000 dev-libs/isl: bump up to 0.24 While at it applied bashism fix by Matt Whitlock. Fix-by: Matt Whitlock Closes: https://bugs.gentoo.org/786564 Package-Manager: Portage-3.0.18, Repoman-3.0.3 Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org> dev-libs/isl/Manifest | 1 + dev-libs/isl/files/isl-0.24-nobash.patch | 35 ++++++++++++++++ dev-libs/isl/isl-0.24.ebuild | 71 ++++++++++++++++++++++++++++++++ 3 files changed, 107 insertions(+) (In reply to Sergei Trofimovich from comment #2) > Can you send the patch upstream as well? > > Should be a matter of sending patch to > https://groups.google.com/g/isl-development I sent on your behalf as https://groups.google.com/g/isl-development/c/GOmQqKVDpRk. I hope it's ok. |
Created attachment 703482 [details, diff] isl-0.23-fix-configure-bashisms.patch isl's configure.ac contains Bashisms (use of == operator with 'test' built-in). Thus, configure emits errors when /bin/sh is not Bash. This doesn't cause the build to fail outright, but it may be causing misdetection of features. AM_CONDITIONAL(SMALL_INT_OPT, test "x$with_int" == "ximath-32") AS_IF([test "x$with_int" == "ximath-32"], [ /var/tmp/portage/dev-libs/isl-0.23-r1/work/isl-0.23/configure: 20657: test: xgmp: unexpected operator /var/tmp/portage/dev-libs/isl-0.23-r1/work/isl-0.23/configure: 20665: test: xgmp: unexpected operator The attached patch removes the Bashisms and allows dev-libs/isl-0.23-r1 to configure without error when /bin/sh is Dash.