| Summary: | games-emulation/pcsx2-9999 compilation fails (CMake Error) due to missing libchdr submodule | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | David Duchesne <aether> |
| Component: | Current packages | Assignee: | nE0sIghT <ykonotopov> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ionen, proxy-maint |
| Priority: | Normal | Keywords: | PullRequest |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://github.com/gentoo/gentoo/pull/20313 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
pcsx2-9999-build.log
CMakeError.log |
||
|
Description
David Duchesne
2021-03-26 11:05:54 UTC
Created attachment 694086 [details]
pcsx2-9999-build.log
---- relevant part of log :
-- Found fmt: 7.1.3
-- Found yaml-cpp: 0.6.3
-- Note that the latest release of yaml-cpp is very outdated, and the bundled submodule in the repo has over a year of bug fixes and as such is preferred.
CMake Error at cmake/SearchForStuff.cmake:292 (add_subdirectory):
The source directory
/var/tmp/portage/games-emulation/pcsx2-9999/work/pcsx2-9999/3rdparty/libchdr/libchdr
does not contain a CMakeLists.txt file.
Call Stack (most recent call first):
CMakeLists.txt:32 (include)
----
Created attachment 694089 [details]
CMakeError.log
This is the commit introducing the issue : https://github.com/PCSX2/pcsx2/commit/51253193e07bdd0dd146f02aebf188feb9dab944 For now, the ebuild needs libchdr added to the list of git submodules: -EGIT_SUBMODULES=() +EGIT_SUBMODULES=( 3rdparty/libchdr/libchdr ) Seems we don't have that one in ::gentoo right now (it's pretty new with no release as of the writing of this, I'd say not worth unbundling yet). https://github.com/rtissera/libchdr (In reply to franklyfrank from comment #4) > For now, the ebuild needs libchdr added to the list of git submodules: > > -EGIT_SUBMODULES=() > +EGIT_SUBMODULES=( 3rdparty/libchdr/libchdr ) Thank you. It now compiles fine again. I temporarily added pcsx2-9999 to my localrepo with that little modification. CHD are great. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=64f20699d4506e962ad688e43c823fb48392c1c3 commit 64f20699d4506e962ad688e43c823fb48392c1c3 Author: Yuri Konotopov <ykonotopov@gnome.org> AuthorDate: 2021-04-09 17:03:11 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2021-04-10 04:24:18 +0000 games-emulation/pcsx2: update to match upstream changes Closes: https://bugs.gentoo.org/778362 Package-Manager: Portage-3.0.17, Repoman-3.0.2 Signed-off-by: Yuri Konotopov <ykonotopov@gnome.org> Closes: https://github.com/gentoo/gentoo/pull/20313 Signed-off-by: Sam James <sam@gentoo.org> games-emulation/pcsx2/pcsx2-9999.ebuild | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) |
