Bug 776682 – dev-vcs/git: drop dev-libs/libpcre2[jit] requirement

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Sam James 2021-03-16 15:04:03 UTC]

I checked out the source and it appears to fall back fine when libpcre2 is built without JIT.

* Tested on SPARC (tests pass except one unrelated failure, git grep -P works);

* Tested on amd64 with USE=jit flipped on libpcre2 both ways without recompiling git once compiled against a certain state, to ensure no ABI breakage occurs (none, as expected due to the pcre2_config call)

So, we can change the dependency in git to dev-libs/libpcre2 and drop the JIT masks: https://github.com/gentoo/gentoo/commit/c77f3ab0d1692784b1b56cee0ef0805ed81f7d42.

[Comment 1 Larry the Git Cow 2021-03-18 09:21:39 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1c1e20adccf8f3dd8476d64e33ac1eba494b858b

commit 1c1e20adccf8f3dd8476d64e33ac1eba494b858b
Author:     Sam James <[e-mail]>
AuthorDate: 2021-03-16 15:22:55 +0000
Commit:     Lars Wendler <[e-mail]>
CommitDate: 2021-03-18 09:21:13 +0000

    profiles/arch: drop obsolete dev-vcs/git[pcre] masks
    
    It turns out that dev-vcs/git[pcre] doesn't need
    dev-libs/libpcre2[jit], just libpcre2 itself.
    
    Closes: https://bugs.gentoo.org/776682
    Signed-off-by: Sam James <[e-mail]>
    Signed-off-by: Lars Wendler <[e-mail]>

 profiles/arch/alpha/package.use.mask      | 1 -
 profiles/arch/hppa/package.use.mask       | 1 -
 profiles/arch/ia64/package.use.mask       | 1 -
 profiles/arch/riscv/package.use.mask      | 1 -
 profiles/arch/sparc/64ul/package.use.mask | 1 -
 5 files changed, 5 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=452a99dc3ec82c3485993a2de5de8d453f6adc24

commit 452a99dc3ec82c3485993a2de5de8d453f6adc24
Author:     Sam James <[e-mail]>
AuthorDate: 2021-03-16 15:20:55 +0000
Commit:     Lars Wendler <[e-mail]>
CommitDate: 2021-03-18 09:21:12 +0000

    dev-vcs/git: don't require JIT on dev-libs/libpcre2
    
    Git detects at runtime whether JIT was compiled in to libpcre2
    and falls back gracefully if it wasn't.
    
    Bug: https://bugs.gentoo.org/776682
    Signed-off-by: Sam James <[e-mail]>
    Signed-off-by: Lars Wendler <[e-mail]>

 dev-vcs/git/{git-2.31.0.ebuild => git-2.31.0-r1.ebuild} | 2 +-
 dev-vcs/git/git-9999-r1.ebuild                          | 2 +-
 dev-vcs/git/git-9999-r2.ebuild                          | 2 +-
 dev-vcs/git/git-9999-r3.ebuild                          | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)