Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 770532

Summary: app-emulation/faudio-21.01 stabilisation (was: switch to CMAKE_ECLASS=cmake)
Product: Gentoo Linux Reporter: Andreas Sturmlechner <asturm>
Component: StabilizationAssignee: Wine Maintainers <wine>
Status: RESOLVED FIXED    
Severity: normal Keywords: STABLEREQ
Priority: Normal Flags: nattka: sanity-check+
Version: unspecified   
Hardware: All   
OS: Linux   
URL: https://archives.gentoo.org/gentoo-dev/message/318c823a723d8e55955e0739a8a7ee15
See Also: https://bugs.gentoo.org/show_bug.cgi?id=741706
https://github.com/gentoo/gentoo/pull/19646
Whiteboard:
Package list:
app-emulation/faudio-21.01
Runtime testing required: ---

Description Andreas Sturmlechner gentoo-dev 2021-02-14 15:38:34 UTC
Small excerpt of cmake.eclass changes:

- Drop all pre-EAPI-7 compatibility
- Drop CMAKE_MIN_VERSION
- Drop CMAKE_REMOVE_MODULES
- Array support for CMAKE_REMOVE_MODULES_LIST
- Drop _cmake_generator_to_use()
- Rename cmake-utils_src_make() -> cmake_build()
- Drop _cmake_ninja_src_make and _cmake_emake_src_make, move into cmake_build

EAPI-8 will be cmake.eclass-only and the CMAKE_ECLASS switch will be obsolete.
Comment 1 Larry the Git Cow gentoo-dev 2021-03-06 17:02:41 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c9a875a5033ae3bf563c9136d0dd120f9c696e2e

commit c9a875a5033ae3bf563c9136d0dd120f9c696e2e
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2021-02-25 11:19:44 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2021-03-06 17:02:22 +0000

    app-emulation/faudio: Switch to cmake.eclass
    
    Drop superfluous COMMON_DEPEND
    Drop superfluous CMAKE_INSTALL_PREFIX, set by cmake.eclass
    
    Use of CMAKE_INSTALL_<dir> variables looks like a workaround of wrong upstream
    usage of GNUInstallDirs but should be fixed upstream.
    
    Closes: https://bugs.gentoo.org/770532
    Package-Manager: Portage-3.0.15, Repoman-3.0.2
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 app-emulation/faudio/faudio-21.01.ebuild | 15 ++++++---------
 app-emulation/faudio/faudio-9999.ebuild  | 15 ++++++---------
 2 files changed, 12 insertions(+), 18 deletions(-)
Comment 2 Andreas Sturmlechner gentoo-dev 2021-03-06 17:07:30 UTC
Re-opening for stabilisation.
Comment 3 Nick Sarnie gentoo-dev 2021-03-06 17:36:53 UTC
CCing arches
Comment 4 Agostino Sarubbo gentoo-dev 2021-03-07 14:45:14 UTC
x86 stable
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-03-08 10:25:43 UTC
amd64 done

all arches done