Bug 759793

Summary:	dev-vcs/subversion[kwallet] depends on kde-frameworks/kdelibs4support
Product:	Gentoo Linux	Reporter:	Andreas Sturmlechner <asturm>
Component:	Current packages	Assignee:	Andreas K. Hüttel <dilfridge>
Status:	RESOLVED FIXED
Severity:	normal	CC:	zlogene
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	755956

Description Andreas Sturmlechner gentoo-dev

2020-12-13 12:26:26 UTC

- Porting away from KDE4 Support is necessary to be in a good place for Qt6
- Package will benefit from a much leaner dependency set

Dependency is only inside DEPEND, so I suspect trivial usage of deprecated kf5-config for path retrieval.

Comment 1 Andreas Sturmlechner gentoo-dev

2020-12-17 12:55:08 UTC

...right. From INSTALL:

> Subversion contains optional support for storing passwords in KWallet.
> Subversion will look for KF5Wallet, KF5CoreAddons, KF5I18n APIs by default,
> and needs kf5-config to find them.
grep finds `kf5-config` inside configure and build/ac-macros/kwallet.m4 and it is basically doing this:

> kde_config_name="kf5-config"
> ...
> AC_PATH_PROG(KDE_CONFIG, $kde_config_name)
>   if test -n "$KDE_CONFIG"; then
>     kde_incdir="`$KDE_CONFIG --install include`"
>     kde_libdir="`$KDE_CONFIG --install lib`"
>   fi
In Gentoo, the values will always end up being:

> kde_incdir=/usr/include/
> kde_libdir=/usr/$(get_libdir)/
Build system should be patched for these variables to use ebuild input and only rely on kf5-config as a fallback so upstream can accept it. Maybe we should have something similar to qmake-utils.eclass for querying standard kf5 paths.

Comment 2 Larry the Git Cow gentoo-dev

2023-04-08 17:23:20 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=02c6b97ab60f971b82f456be7186160fd2d93ebb

commit 02c6b97ab60f971b82f456be7186160fd2d93ebb
Author:     Andreas K. Hüttel <dilfridge@gentoo.org>
AuthorDate: 2023-04-08 17:21:38 +0000
Commit:     Andreas K. Hüttel <dilfridge@gentoo.org>
CommitDate: 2023-04-08 17:23:09 +0000

    dev-vcs/subversion: Hardwire kf5 paths, drop kdelibs4support dep
    
    No patches needed, configure arguments work
    
    Closes: https://bugs.gentoo.org/759793
    Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org>

 dev-vcs/subversion/subversion-1.14.2-r1.ebuild | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)