Bug 759793

Summary:	dev-vcs/subversion[kwallet] depends on kde-frameworks/kdelibs4support
Product:	Gentoo Linux	Reporter:	Andreas Sturmlechner <asturm>
Component:	Current packages	Assignee:	Andreas K. Hüttel <dilfridge>
Status:	CONFIRMED ---
Severity:	normal	CC:	zlogene
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	755956

Description Andreas Sturmlechner gentoo-dev

2020-12-13 12:26:26 UTC

- Porting away from KDE4 Support is necessary to be in a good place for Qt6
- Package will benefit from a much leaner dependency set

Dependency is only inside DEPEND, so I suspect trivial usage of deprecated kf5-config for path retrieval.

Comment 1 Andreas Sturmlechner gentoo-dev

2020-12-17 12:55:08 UTC

...right. From INSTALL:

> Subversion contains optional support for storing passwords in KWallet.
> Subversion will look for KF5Wallet, KF5CoreAddons, KF5I18n APIs by default,
> and needs kf5-config to find them.
grep finds `kf5-config` inside configure and build/ac-macros/kwallet.m4 and it is basically doing this:

> kde_config_name="kf5-config"
> ...
> AC_PATH_PROG(KDE_CONFIG, $kde_config_name)
>   if test -n "$KDE_CONFIG"; then
>     kde_incdir="`$KDE_CONFIG --install include`"
>     kde_libdir="`$KDE_CONFIG --install lib`"
>   fi
In Gentoo, the values will always end up being:

> kde_incdir=/usr/include/
> kde_libdir=/usr/$(get_libdir)/
Build system should be patched for these variables to use ebuild input and only rely on kf5-config as a fallback so upstream can accept it. Maybe we should have something similar to qmake-utils.eclass for querying standard kf5 paths.