| Summary: | media-libs/opencolorio-1.1.1: stabilisation | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Sam James <sam> | ||||
| Component: | Stabilization | Assignee: | No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | normal | Keywords: | CC-ARCHES | ||||
| Priority: | Normal | Flags: | nattka:
sanity-check+
|
||||
| Version: | unspecified | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Package list: |
media-libs/opencolorio-1.1.1
|
Runtime testing required: | --- | ||||
| Bug Depends on: | |||||||
| Bug Blocks: | 754909 | ||||||
| Attachments: |
|
||||||
|
Description
Sam James
2020-11-16 19:38:06 UTC
Not sure where to post this, but on one of my clang boxes, 1.1.1 failed to build with this error: /var/tmp/portage/media-libs/opencolorio-1.1.1/work/OpenColorIO-1.1.1/src/core/Config.cpp:333:35: error: assigning field to itself [-Werror,-Wself-assign-field] The following patch fixed the build. Created attachment 671680 [details, diff]
opencolorio-1.1.1-config-fix-self-assignment.patch
(In reply to 0xC0ncord from comment #1) > Not sure where to post this, but on one of my clang boxes, 1.1.1 failed to > build with this error: > > /var/tmp/portage/media-libs/opencolorio-1.1.1/work/OpenColorIO-1.1.1/src/ > core/Config.cpp:333:35: error: assigning field to itself > [-Werror,-Wself-assign-field] > > The following patch fixed the build. Thanks! Fixed upstream in https://github.com/AcademySoftwareFoundation/OpenColorIO/commit/0be465feb9ac2d34bd8171f30909b276c1efa996#diff-1c73f65d469e79d569e1189d6163165834fcdf608a5b70f374075f52ee356a34. (Upstream bug: https://github.com/AcademySoftwareFoundation/OpenColorIO/issues/563). Does the upstream patch work for you? It looks a bit more invasive so I guess I'm more inclined to go with yours. Also, could you share the GCO sign off please? (Signed-off-by: Real Name <email>) amd64 done (In reply to Sam James from comment #3) > Does the upstream patch work for you? It looks a bit more invasive so I > guess I'm more inclined to go with yours. It seems like that patch needs some reworking to get to apply cleanly to 1.1.1, since many path names were changed since that commit. > Also, could you share the GCO sign off please? (Signed-off-by: Real Name > <email>) Sorry about that! (Signed-off-by: 0xC0ncord <me@concord.sh>) x86 stable. Closing. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=175603a404585a7e5c045c4bab7982b617bec5cd commit 175603a404585a7e5c045c4bab7982b617bec5cd Author: Sam James <sam@gentoo.org> AuthorDate: 2020-11-18 19:20:55 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2020-11-18 19:21:00 +0000 media-libs/opencolorio: fix Clang build Thanks-to: 0xC0ncord <me@concord.sh> Bug: https://bugs.gentoo.org/754966 Package-Manager: Portage-3.0.9, Repoman-3.0.2 Signed-off-by: Sam James <sam@gentoo.org> .../files/opencolorio-1.1.1-fix-self-assign-clang.patch | 14 ++++++++++++++ media-libs/opencolorio/opencolorio-1.1.1.ebuild | 1 + 2 files changed, 15 insertions(+) (In reply to 0xC0ncord from comment #5) > (In reply to Sam James from comment #3) > > Does the upstream patch work for you? It looks a bit more invasive so I > > guess I'm more inclined to go with yours. > > It seems like that patch needs some reworking to get to apply cleanly to > 1.1.1, since many path names were changed since that commit. > > > Also, could you share the GCO sign off please? (Signed-off-by: Real Name > > <email>) > > Sorry about that! > > (Signed-off-by: 0xC0ncord <me@concord.sh>) I have a feeling that might not be your real name, but it's a simple enough change (and the only possible fix), so it's fine ;) |