Summary: | media-gfx/gimp: migrate to lua eclasses | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Marek Szuba <marecki> |
Component: | Current packages | Assignee: | Sergey Torokhov <torokhov-s-a> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | proxy-maint |
Priority: | Normal | Keywords: | PullRequest |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://github.com/gentoo/gentoo/pull/18768 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 757873 | ||
Attachments: |
gimp-2.99.2-r100.ebuild
gimp-9999.ebuild |
Description
Marek Szuba
2020-11-03 15:37:01 UTC
gimp-2.99.2 and -9999 currently require lua only in runtime and don't use lua to build plugins and extensions that are provided by gimp and just installed into package directory. Lua presence is only checked on configuration phase. It seems that in this situation lua-single.eclass is suitable, isn't it? I would say you are correct. That's how I have treated most packages which do run-time Lua evaluation anyway. In some ported ebuilds I see LUA_COMPAT=( luajit ) but I don't see any information about this implementation in devmanual or directly within lua{,-single}.eclass code. @Marek Szuba could you please provide the url to description of that and "LUAJIT_*" etc? The development gimp versions depend from dev-lang/luajit and dev-lua/lgi. If you look inside lua-utils.eclass you will find that luajit is in fact very much on the list of supported implementations. Not sure what else you need, IIRC the only difference between LuaJIT and other implementations as far as eclasses are concerned is that "luac" created by the wrapper is in fact /bin/true. Attaching migrated ebuilds, please review - especially the migration to EAPI-7, in particular the list of DEPEND atoms which should be moved to BDEPEND. Created attachment 679263 [details]
gimp-2.99.2-r100.ebuild
Created attachment 679266 [details]
gimp-9999.ebuild
Finally, moving this to the non-blocking tracker thanks to the fact neither of the lua-revdep GIMP ebuilds have any keywords. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=52b195c1624b27428e4fca190e0ab4316cf52d2d commit 52b195c1624b27428e4fca190e0ab4316cf52d2d Author: Marek Szuba <marecki@gentoo.org> AuthorDate: 2020-12-26 22:15:10 +0000 Commit: Marek Szuba <marecki@gentoo.org> CommitDate: 2020-12-26 23:18:19 +0000 media-gfx/gimp/gimp: migrate to lua-single.eclass Latest 2.99 and the live ebuild; older versions do not depend on Lua. Approved by the maintainer via comment in the GitHub PR #18768. Also includes the requested Pango version bump in the dependencies of 9999. Closes: https://bugs.gentoo.org/752747 Closes: https://bugs.gentoo.org/755962 Signed-off-by: Marek Szuba <marecki@gentoo.org> media-gfx/gimp/gimp-2.99.2-r100.ebuild | 257 +++++++++++++++++++++++++++++++++ media-gfx/gimp/gimp-9999.ebuild | 32 ++-- 2 files changed, 277 insertions(+), 12 deletions(-) |