Summary: | sys-fs/cryfs-0.10.2: -DCMAKE_BUILD_TYPE=Gentoo builds a debug build | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Tamas Jantvik <tsjk> |
Component: | Current packages | Assignee: | No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | jstein, nickAristocrates, sam |
Priority: | Normal | Keywords: | PullRequest |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://github.com/gentoo/gentoo/pull/18096 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Tamas Jantvik
2020-10-09 06:26:29 UTC
If I add -DNDEBUG in the ebuild using append-flags, it gets rid of the warning for me. I'm not 100% sure this is the most correct and future-proof way to disable the development build, but I see something similar done in dev-util/intel-graphics-compiler: https://github.com/gentoo/gentoo/blob/a50597d0202a4968147c1b5d96ebeeb1872b0ffe/dev-util/intel-graphics-compiler/intel-graphics-compiler-1.0.4111.ebuild#L50-L52 > # Since late March 2020 cmake.eclass does not set -DNDEBUG any more, and the way > # IGC uses this definition causes problems for some users (see Bug #718824). > use debug || append-cppflags -DNDEBUG From the discussion in an upstream issue (https://github.com/cryfs/cryfs/issues/147) I'm not sure whether there is much of a known performance impact, but I can confirm that the warning goes away and that the following command: file `which cryfs` gives "stripped" which I assume means it does not contain debugging symbols. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e1b4322ae72c88dbd03fb66cd1c60a7e04a07a93 commit e1b4322ae72c88dbd03fb66cd1c60a7e04a07a93 Author: Nicholas Meyer <nickaristocrates@gmail.com> AuthorDate: 2020-10-31 22:34:34 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2020-11-05 12:32:03 +0000 sys-fs/cryfs: remove debug warning on sys-fs/cryfs[-debug] Closes: https://bugs.gentoo.org/747376 Signed-off-by: Nicholas Meyer <nickaristocrates@gmail.com> Signed-off-by: Joonas Niilola <juippis@gentoo.org> sys-fs/cryfs/cryfs-0.10.2.ebuild | 1 + 1 file changed, 1 insertion(+) |