Bug 744859

Summary:	media-libs/avidemux-plugins-2.7.6: unnecessary dep dev-lang/spidermonkey:0 and subsequently dev-lang/python-2.7
Product:	Gentoo Linux	Reporter:	Petr Zima <zima>
Component:	Current packages	Assignee:	Gentoo Media-video project <media-video>
Status:	RESOLVED FIXED
Severity:	major	CC:	gentoo-bugzilla, jstein, kroemmelbein, M4rkusXXL, o.freyermuth, python, sam
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://bugs.gentoo.org/show_bug.cgi?id=721710 https://github.com/gentoo/gentoo/pull/21347
Whiteboard:
Package list:		Runtime testing required:	---

Description Petr Zima 2020-09-26 19:08:19 UTC

The dependency on spidermonkey (which pulls in also python-2.7) is redundant. The spidermonkey plugin is not built by default anymore and the ebuild is not asking for it. Consult the source file avidemux_plugins/ADM_scriptEngines/CMakeLists.txt where it is commented out. Cf. also Bug #721710.

Reproducible: Always

Comment 1 Petr Zima 2020-09-26 19:12:29 UTC

The ebuild could use some polishing and more use flags to make more plugins optional and use system libraries, e.g. the python scripting plugin, ffmpeg dependency etc.

Comment 2 Petr Zima 2021-05-18 07:45:57 UTC

What's the problem here? Simply removing the spidermonkey dep DOES NOT AFFECT the build at all, you can check for yourself. See also bug #777909 for bumped ebuilds.

Comment 3 Rob Burcham 2021-10-04 16:23:43 UTC

Confirm this one.  I also can add that for me the dependency blocks a deep update world by trying to pull in python 2.7.

But if I simply rebuild the spidermonkey and avidemux-plugins independently the python 2.7 dep does not trigger.  Which is confusing to me.

To bypass I unmerged 

=dev-lang/spidermonkey-1.8.5-r9
=media-libs/avidemux-plugins-2.7.6
=media-video/avidemux-2.7.6-r1

then edited out the spidermonkey dep from the avidemux-plugins ebuild, then re-merged avidemux.

Comment 4 Larry the Git Cow gentoo-dev

2021-11-07 00:01:26 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=841bd92580e87739852b51a4b2c0357a64366e17

commit 841bd92580e87739852b51a4b2c0357a64366e17
Author:     Marco Scardovi <marco@scardovi.com>
AuthorDate: 2021-06-20 18:20:25 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-11-07 00:01:16 +0000

    media-libs/avidemux-plugins: bump to 2.7.8
    
    Drop spidermonkey as it isn't required anymore.
    
    Closes: https://bugs.gentoo.org/744859
    Closes: https://bugs.gentoo.org/777909
    Package-Manager: Portage-3.0.20, Repoman-3.0.3
    Signed-off-by: Marco Scardovi <marco@scardovi.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 media-libs/avidemux-plugins/Manifest               |   1 +
 .../avidemux-plugins/avidemux-plugins-2.7.8.ebuild | 165 +++++++++++++++++++++
 2 files changed, 166 insertions(+)