Summary: | net-analyzer/fragroute depends on dev-libs/libdnet[ipv6] | ||||||
---|---|---|---|---|---|---|---|
Product: | Gentoo Linux | Reporter: | Konrad Karczewski <konrad.karczewski> | ||||
Component: | Stabilization | Assignee: | Gentoo Netmon project <netmon> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | normal | CC: | mgorny, sam, treecleaner | ||||
Priority: | Normal | Keywords: | CC-ARCHES, STABLEREQ | ||||
Version: | unspecified | Flags: | nattka:
sanity-check+
|
||||
Hardware: | All | ||||||
OS: | Linux | ||||||
URL: | https://qa-reports.gentoo.org/output/gentoo-ci/b70e70940b/output.html;pkg=net-analyzer/fragroute | ||||||
See Also: |
https://github.com/ofalk/libdnet/issues/54 https://github.com/stsi/fragroute-ipv6/issues/2 https://github.com/ofalk/libdnet/pull/56 |
||||||
Whiteboard: | |||||||
Package list: |
net-analyzer/fragroute-1.2.6-r4 amd64 x86
|
Runtime testing required: | --- | ||||
Bug Depends on: | |||||||
Bug Blocks: | 694800 | ||||||
Attachments: |
|
Description
Konrad Karczewski
2020-09-24 08:23:57 UTC
Created attachment 662275 [details]
new libdnet-1.14 ebuild
The attached ebuild restores the ipv6 flag, and both libdnet-1.14 and net-analyzer/fragroute-1.2.6-r3 build correctly with it in place. I didn't test fragroute to any extend, but since the creator is the provider of this libdnet patch I assume it works OK.
Comment on attachment 662275 [details]
new libdnet-1.14 ebuild
Not going to do that. Upstream for libdnet needs to implement these changes officially to expose the new API features.
As you can see from the See alsos, this process was set in motion some time ago, and the new API features have been implemented but not yet released. If you want to actually help, then you will need to ask libdnet developers to release a new version with those changes.
(In reply to Jeroen Roovers from comment #2) > Comment on attachment 662275 [details] > new libdnet-1.14 ebuild > > Not going to do that. Upstream for libdnet needs to implement these changes > officially to expose the new API features. > > As you can see from the See alsos, this process was set in motion some time > ago, and the new API features have been implemented but not yet released. If > you want to actually help, then you will need to ask libdnet developers to > release a new version with those changes. For context, libdnet development was in limbo for years, so the previous addition of the "ndisc/ipv6" patch from the fragroute authors seemed fine. With recent changes in the life of libdnet, however, adding patches in that way is not ideal. For instance, the "ndisc" addition to the previously added IPv6 support should be accompanied with a libtool version/SONAME change[0], as the users of libdnet should be able to find out whether it supports the new feature. [0] https://github.com/ofalk/libdnet/commit/1c324828f4c6c64c9340f169bc059152dba1f998#r42743515 I suppose this means that fragroute is on its way out. (In reply to Michał Górny from comment #4) > I suppose this means that fragroute is on its way out. No, it does not. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f299f49c951d680113412807a38a90c5024aba57 commit f299f49c951d680113412807a38a90c5024aba57 Author: Jeroen Roovers <jer@gentoo.org> AuthorDate: 2020-09-27 10:06:06 +0000 Commit: Jeroen Roovers <jer@gentoo.org> CommitDate: 2020-09-27 10:06:56 +0000 net-analyzer/fragroute: Depend on >=dev-libs/libdnet-1.14-r1 Package-Manager: Portage-3.0.8, Repoman-3.0.1 Bug: https://bugs.gentoo.org/744484 Signed-off-by: Jeroen Roovers <jer@gentoo.org> net-analyzer/fragroute/fragroute-1.2.6-r4.ebuild | 54 ++++++++++++++++++++++++ 1 file changed, 54 insertions(+) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=af1632be53234f09ff25a70576f4f98a782d405a commit af1632be53234f09ff25a70576f4f98a782d405a Author: Jeroen Roovers <jer@gentoo.org> AuthorDate: 2020-09-27 10:02:00 +0000 Commit: Jeroen Roovers <jer@gentoo.org> CommitDate: 2020-09-27 10:06:54 +0000 dev-libs/libdnet: Add ndisc patch Package-Manager: Portage-3.0.8, Repoman-3.0.1 Bug: https://bugs.gentoo.org/744484 Signed-off-by: Jeroen Roovers <jer@gentoo.org> dev-libs/libdnet/files/libdnet-1.14-ndisc.patch | 796 ++++++++++++++++++++++++ dev-libs/libdnet/libdnet-1.14-r1.ebuild | 78 +++ 2 files changed, 874 insertions(+) Since the ndisc feature in libdnet is used solely by fragroute, I decided that as long as the in-tree usage is consistent, there should be no need to wait for libdnet upstream to release a new version with the API changes. Unable to check for sanity:
> invalid use of ^ keyword on first line
amd64 done all arches done |