| Summary: | app-emulation/qemu-9999 USE=sdl-image - src_configure(): ../meson.build:253:4: ERROR: Expected 1 arguments, got 2. | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Rafael Kitover <rkitover> |
| Component: | Current packages | Assignee: | Matthias Maier <tamiko> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | slyfox, virtualization |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
emerge --info
build.log meson.log |
||
|
Description
Rafael Kitover
2020-09-07 08:05:51 UTC
Created attachment 658938 [details]
emerge --info
Created attachment 658940 [details]
build.log
Created attachment 658942 [details]
meson.log
Looks like the failure here is missing 'sdl' flag when 'sdl-image' is requested, but error() call is invalid:
if sdl.found()
# work around 2.0.8 bug
sdl = declare_dependency(compile_args: '-Wno-undef',
dependencies: sdl)
sdl_image = dependency('SDL2_image', required: get_option('sdl_image'),
method: 'pkg-config', static: enable_static)
else
if get_option('sdl_image').enabled()
error('sdl-image required, but SDL was @0@',
get_option('sdl').disabled() ? 'disabled' : 'not found')
endif
sdl_image = not_found
endif
(In reply to Sergei Trofimovich from comment #4) > Looks like the failure here is missing 'sdl' flag when 'sdl-image' is > requested, but error() call is invalid: > error('sdl-image required, but SDL was @0@', > get_option('sdl').disabled() ? 'disabled' : 'not found') https://mesonbuild.com/Reference-manual.html#error says it's a single-argument function. SHould use .format(). The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3752d632441c34385ee7296126e3867536cb63e7 commit 3752d632441c34385ee7296126e3867536cb63e7 Author: Sergei Trofimovich <slyfox@gentoo.org> AuthorDate: 2020-09-08 07:33:11 +0000 Commit: Sergei Trofimovich <slyfox@gentoo.org> CommitDate: 2020-09-08 07:33:20 +0000 app-emulation/qemu: tweak error message for missing SDL Reported-by: Rafael Kitover Bug: https://bugs.gentoo.org/740836 Package-Manager: Portage-3.0.5, Repoman-3.0.1 Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org> app-emulation/qemu/files/qemu-9999-format-error.patch | 14 ++++++++++++++ app-emulation/qemu/qemu-9999.ebuild | 1 + 2 files changed, 15 insertions(+) The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9ab61b9162819825424a6f30edb0a2d3290fd56f commit 9ab61b9162819825424a6f30edb0a2d3290fd56f Author: Sergei Trofimovich <slyfox@gentoo.org> AuthorDate: 2020-09-08 08:17:36 +0000 Commit: Sergei Trofimovich <slyfox@gentoo.org> CommitDate: 2020-09-08 08:17:48 +0000 app-emulation/qemu: enable sdl-image only for softmmu qemu's build system became sightly stricter and disallows 'sdl-image' support without 'sdl' support. The check only makes sense for softmmu build, but is done for all types of builds. The change disables 'sdl-image' flag for 'user' and 'tools' builds. Reported-by: Rafael Kitover Closes: https://bugs.gentoo.org/740836 Package-Manager: Portage-3.0.5, Repoman-3.0.1 Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org> app-emulation/qemu/qemu-9999.ebuild | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) Looks like the .format() fix was applied upstream and the patch can be removed. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b3ce8bbed78b0651008ec4c5e40df1de8e0f5052 commit b3ce8bbed78b0651008ec4c5e40df1de8e0f5052 Author: Sergei Trofimovich <slyfox@gentoo.org> AuthorDate: 2020-09-19 07:31:53 +0000 Commit: Sergei Trofimovich <slyfox@gentoo.org> CommitDate: 2020-09-19 07:33:01 +0000 app-emulation/qemu: drop upstreamed patch This reverts commit 3752d632441c34385ee7296126e3867536cb63e7. Bug: https://bugs.gentoo.org/740836 Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org> app-emulation/qemu/files/qemu-9999-format-error.patch | 14 -------------- app-emulation/qemu/qemu-9999.ebuild | 1 - 2 files changed, 15 deletions(-) |
