Summary: | dev-lang/lua-{5.2,5.3} incorrectly use $EROOT which should be $BROOT (PATCH) | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Ed Wildgoose <gentoo> |
Component: | Current packages | Assignee: | William Hubbs <williamh> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | jstein, robbat2, sam |
Priority: | Normal | Keywords: | PATCH, PullRequest |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: |
https://bugs.gentoo.org/show_bug.cgi?id=791451 https://bugs.gentoo.org/show_bug.cgi?id=515554 https://github.com/gentoo/gentoo/pull/24018 https://github.com/gentoo/gentoo/pull/24359 |
||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Ed Wildgoose
2020-08-31 18:07:13 UTC
The variable BROOT has only been available since EAPI-7. As of right now, all but one dev-lang/lua ebuilds in the tree use EAPI=5; the remaining one (5.1.5-r5) uses EAPI=6. In other words, this is something to keep in mind once we have begun migrating dev-lang/lua ebuilds to EAPI-7 - but until then this change would actually break things. Hi, Can I reopen this please. I hear what you say. However, I guess that the initial problem still remains, therefore: a) Could we start the eapi=7 process with this ebuild? And apply the change noted? b) I suspect then that although my specific suggestion is wrong, there is probably an eapi=6 solution, perhaps by completely ommitting ${BROOT} or similar? I guess I'm a bit confused about why we are trying to use EROOT at all? Probably there is some previous problem that this was intended to resolve, but I can't really think what? Seems incorrect at first glance? My vote would be a), what do you think? Repeat, that as of today, the ebuild does NOT compile when compiling into an alternate "ROOT=something" location because of this, so I would like to try and find a solution please? Ta I'm not sure why the makefiles were using EROOT or BROOT this way, so I removed those references in the slotted lua ebuilds. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1788cd986db0c35c7300d7727f8471a4f11062a1 commit 1788cd986db0c35c7300d7727f8471a4f11062a1 Author: William Hubbs <williamh@gentoo.org> AuthorDate: 2020-12-30 17:01:48 +0000 Commit: William Hubbs <williamh@gentoo.org> CommitDate: 2020-12-30 17:03:27 +0000 dev-lang/lua: remove unneeded reference to BROOT in patches Bug: https://bugs.gentoo.org/739764 Signed-off-by: William Hubbs <williamh@gentoo.org> dev-lang/lua/files/lua-5.4.2-make.patch | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) The patch above has broken the build on prefix:
>>> Compiling source in /tmp/portage/dev-lang/lua-5.4.2-r1/work/lua-5.4.2 ...
* abi_x86_64.amd64: running multilib-minimal_abi_src_compile
make -j4 -l4 CC=x86_64-pc-linux-gnu-gcc 'CFLAGS=-DLUA_COMPAT_5_3 -DLUA_USE_READLINE -DLUA_USE_LINUX -O2 -pipe -O2 -pipe' 'SYSLDFLAGS=-Wl,-O1 -Wl,--as-needed' RPATH=/cvmfs/sft.cern.ch/lcg/contrib/gentoo/linux/x86_64/usr/lib64/ LUA_LIBS=-lreadline 'LIB_LIBS=-lm -ldl' V=5.4 gentoo_all
/usr/bin/libtool --quiet --tag=CC --mode=compile x86_64-pc-linux-gnu-gcc -c -DLUA_COMPAT_5_3 -DLUA_USE_READLINE -DLUA_USE_LINUX -O2 -pipe -O2 -pipe -o lapi.lo lapi.c
make: /usr/bin/libtool: No such file or directory
make: *** [Makefile:232: lapi.lo] Error 127
* ERROR: dev-lang/lua-5.4.2-r1::gentoo failed (compile phase):
* emake failed
Please revert or fix by adding EROOT/BROOT/EPREFIX, whichever you think is the correct one to use in this context.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3f0c95ca346af106169ceef830e4e0ae5ea3eed2 commit 3f0c95ca346af106169ceef830e4e0ae5ea3eed2 Author: Alexandra Parker <alex.iris.parker@gmail.com> AuthorDate: 2022-01-31 03:01:47 +0000 Commit: William Hubbs <williamh@gentoo.org> CommitDate: 2022-02-14 07:33:58 +0000 dev-lang/lua:5.1.5-r107 5.3.6-r3 bump - Cross-compile fix, use libtol on the target system and move libtool to DEPEND instead of BDEPEND. Closes: https://bugs.gentoo.org/515554 Closes: https://bugs.gentoo.org/739764 Closes: https://github.com/gentoo/gentoo/pull/24018 Package-Manager: Portage-3.0.30, Repoman-3.0.3 Signed-off-by: Alexandra Parker <alex.iris.parker@gmail.com> Signed-off-by: William Hubbs <williamh@gentoo.org> dev-lang/lua/lua-5.1.5-r107.ebuild | 157 ++++++++++++++++++++++++++++ dev-lang/lua/lua-5.3.6-r3.ebuild | 206 +++++++++++++++++++++++++++++++++++++ 2 files changed, 363 insertions(+) The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e75caee08ab5c8d0bf72f1cf3d7bfc12361ec0ce commit e75caee08ab5c8d0bf72f1cf3d7bfc12361ec0ce Author: Alexey Sokolov <alexey+gentoo@asokolov.org> AuthorDate: 2022-02-26 12:42:16 +0000 Commit: William Hubbs <williamh@gentoo.org> CommitDate: 2022-03-03 15:41:42 +0000 dev-lang/lua: fix 5.4 build on prefix Similar to how it was fixed for lua 5.3 Closes: https://bugs.gentoo.org/739764 Closes: https://github.com/gentoo/gentoo/pull/24359 Package-Manager: Portage-3.0.30, Repoman-3.0.3 Signed-off-by: Alexey Sokolov <alexey+gentoo@asokolov.org> Signed-off-by: William Hubbs <williamh@gentoo.org> dev-lang/lua/files/lua-5.4.2-r2-make.patch | 99 ++++++++++++++ dev-lang/lua/lua-5.4.2-r2.ebuild | 203 +++++++++++++++++++++++++++++ dev-lang/lua/lua-5.4.4.ebuild | 2 +- 3 files changed, 303 insertions(+), 1 deletion(-) |