Summary: | >dev-python/wtforms-2.3.1: Optional RDEPEND on dev-python/python-email-validator - (dev-db/pgadmin4: Exception: Install 'email_validator' for email validation support.) | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | martin.schmidt13 |
Component: | Current packages | Assignee: | Python Gentoo Team <python> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | andrey_utkin, daniel, martin.schmidt13, mehmet, mgorny, pgsql-bugs |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | 755260 | ||
Bug Blocks: |
Description
martin.schmidt13
2020-08-01 07:32:06 UTC
*** Bug 736976 has been marked as a duplicate of this bug. *** This doesn't appear to be an issue with dev-db/pgadmin4. I don't have python-email-validator installed, and PgAdmin 4 starts without an issue. It's also been reported on Bug 736976 that the following packages are needed: - dev-python/extras - dev-python/fixtures - dev-python/linecache2 - dev-python/pycodestyle - dev-python/python-mimeparse - dev-python/testscenarios - dev-python/testtools - dev-python/traceback2 - dev-python/selenium - dev-python/coverage - dev-python/python-email-validator More than half of those packages are not installed on my system, and 4.25 works without an issue. Instead, it looks like the dev-python/python-email-validator needs to be RDEPENDed in dev-python/wtforms packaged. I'm not sure about the others. The error i reported is with "stable" pgadmin4-4.17-r1 i run. Perhaps i should now try pgadmin4-4.25 - born 4 hours ago ... :-) (In reply to martin.schmidt13 from comment #3) > The error i reported is with "stable" pgadmin4-4.17-r1 i run. > Perhaps i should now try pgadmin4-4.25 - born 4 hours ago ... :-) Poor wording on my part. I meant that 4.17 has always worked, and 4.25 works as well. Which version of dev-python/wtforms do you have installed? (In reply to Aaron W. Swenson from comment #4) > (In reply to martin.schmidt13 from comment #3) > > The error i reported is with "stable" pgadmin4-4.17-r1 i run. > > Perhaps i should now try pgadmin4-4.25 - born 4 hours ago ... :-) > > Poor wording on my part. I meant that 4.17 has always worked, and 4.25 works > as well. > > Which version of dev-python/wtforms do you have installed? equery l dev-python/wtforms * Searching for wtforms in dev-python ... [IP-] [ ] dev-python/wtforms-2.3.1:0 (In reply to Aaron W. Swenson from comment #2) > This doesn't appear to be an issue with dev-db/pgadmin4. I don't have > python-email-validator installed, and PgAdmin 4 starts without an issue. > > > It's also been reported on Bug 736976 that the following packages are needed: > - dev-python/extras > - dev-python/fixtures > - dev-python/linecache2 > - dev-python/pycodestyle > - dev-python/python-mimeparse > - dev-python/testscenarios > - dev-python/testtools > - dev-python/traceback2 > - dev-python/selenium > - dev-python/coverage > - dev-python/python-email-validator > > More than half of those packages are not installed on my system, and 4.25 > works without an issue. > > Instead, it looks like the dev-python/python-email-validator needs to be > RDEPENDed in dev-python/wtforms packaged. I'm not sure about the others. Wouldn't that mean python-email-validator needs to be present anyway ? (In reply to martin.schmidt13 from comment #6) > (In reply to Aaron W. Swenson from comment #2) > > This doesn't appear to be an issue with dev-db/pgadmin4. I don't have > > python-email-validator installed, and PgAdmin 4 starts without an issue. > > > > ... > > > > Instead, it looks like the dev-python/python-email-validator needs to be > > RDEPENDed in dev-python/wtforms packaged. I'm not sure about the others. > > Wouldn't that mean python-email-validator needs to be present anyway ? Yes, but we need to determine the package that actually needs it. PgAdmin doesn't need it, per se. So, it shouldn't declare a dependency on it. It looks like starting with dev-python/wtforms-2.3.1, the email validation was shifted to an optional dependency, dev-python/python-email-validator. With <dev-python/wtforms-2.3.1, they managed a regex themselves. So, we need dev-python/python-email-validator to allow us to flip the email validation support on. @python: What USE flag would we like to use? Don't bother users with flipping meaningless flags, add the dep to pgadmin4. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=124f7ccffce5387371bb24e04a276783e09b60d3 commit 124f7ccffce5387371bb24e04a276783e09b60d3 Author: Aaron W. Swenson <titanofold@gentoo.org> AuthorDate: 2020-09-24 09:46:04 +0000 Commit: Aaron W. Swenson <titanofold@gentoo.org> CommitDate: 2020-09-24 09:49:27 +0000 dev-db/pgadmin4: Bump to 4.26 Added indirect dependency on dev-python/python-email-validator. Bug: https://bugs.gentoo.org/735014 Signed-off-by: Aaron W. Swenson <titanofold@gentoo.org> dev-db/pgadmin4/Manifest | 1 + dev-db/pgadmin4/pgadmin4-4.26.ebuild | 128 +++++++++++++++++++++++++++++++++++ 2 files changed, 129 insertions(+) The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f997bdc5009d9b7b78b57ddf1494867268eaca13 commit f997bdc5009d9b7b78b57ddf1494867268eaca13 Author: Aaron W. Swenson <titanofold@gentoo.org> AuthorDate: 2020-12-25 03:16:08 +0000 Commit: Aaron W. Swenson <titanofold@gentoo.org> CommitDate: 2020-12-25 03:16:08 +0000 dev-db/pgadmin4: Cleanup Closes: https://bugs.gentoo.org/735014 Closes: https://bugs.gentoo.org/744151 Signed-off-by: Aaron W. Swenson <titanofold@gentoo.org> dev-db/pgadmin4/Manifest | 3 - .../pgadmin4/files/pgadmin4-4.17-python-3.8.patch | 12 -- dev-db/pgadmin4/pgadmin4-4.17-r1.ebuild | 120 ------------------- dev-db/pgadmin4/pgadmin4-4.25.ebuild | 124 -------------------- dev-db/pgadmin4/pgadmin4-4.28.ebuild | 130 --------------------- 5 files changed, 389 deletions(-) |