Summary: | dev-libs/gobject-introspection[-doctool] installs unused doctool python files | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Toralf Förster <toralf> |
Component: | Current packages | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
Status: | CONFIRMED --- | ||
Severity: | normal | CC: | sam |
Priority: | Normal | Keywords: | TESTFAILURE |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://bugs.gentoo.org/show_bug.cgi?id=719252 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
emerge-info.txt
dev-libs:gobject-introspection-1.64.1-r1:20200722-233216.log emerge-history.txt environment etc.portage.tbz2 logs.tbz2 temp.tbz2 tests.tbz2 |
Description
Toralf Förster
2020-07-23 18:45:10 UTC
Created attachment 650344 [details]
emerge-info.txt
Created attachment 650346 [details]
dev-libs:gobject-introspection-1.64.1-r1:20200722-233216.log
Created attachment 650348 [details]
emerge-history.txt
Created attachment 650350 [details]
environment
Created attachment 650352 [details]
etc.portage.tbz2
Created attachment 650354 [details]
logs.tbz2
Created attachment 650356 [details]
temp.tbz2
Created attachment 650358 [details]
tests.tbz2
31/61 test_docwriter.py FAIL 1.41s (exit status 1) --- command --- 11:34:48 PYTHONPATH='/var/tmp/portage/dev-libs/gobject-introspection-1.64.1-r1/work/gobject-introspection-1.64.1-build' /usr/bin/python3.7 /var/tmp/portage/dev-libs/gobject-introspection-1.64.1-r1/work/gobject-introspection-1.64.1-build/../gobject-introspection-1.64.1/tests/scanner/test_docwriter.py --- stderr --- Traceback (most recent call last): File "/var/tmp/portage/dev-libs/gobject-introspection-1.64.1-r1/work/gobject-introspection-1.64.1-build/../gobject-introspection-1.64.1/tests/scanner/test_docwriter.py", line 10, in <module> from giscanner.docwriter import DocWriter File "/var/tmp/portage/dev-libs/gobject-introspection-1.64.1-r1/work/gobject-introspection-1.64.1-build/giscanner/docwriter.py", line 30, in <module> import markdown ModuleNotFoundError: No module named 'markdown' ------- Nice easy win, it seems. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e9ef239fbf4e16b0dc6871513578533e0e99739d commit e9ef239fbf4e16b0dc6871513578533e0e99739d Author: Matt Turner <mattst88@gentoo.org> AuthorDate: 2020-08-19 23:31:21 +0000 Commit: Matt Turner <mattst88@gentoo.org> CommitDate: 2020-08-19 23:53:54 +0000 dev-libs/gobject-introspection: Depend on mako and markdown for tests test_docwriter.py looks to requires dev-python/mako, and via giscanner/docwriter.py, dev-python/markdown. The test contains @unittest.skipUnless(HAS_MAKO, "mako missing") which skips the test if mako is not available, but it does not check whether markdown is also available. In the case that mako is available but markdown is not, the test will run and fail to import markdown. These are common and small dependencies. Let's just require both of them for tests. Closes: https://bugs.gentoo.org/733668 Signed-off-by: Matt Turner <mattst88@gentoo.org> .../gobject-introspection/gobject-introspection-1.64.1-r1.ebuild | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) Issues like these need to get handled upstream too, before considered fixed, especially it means a workaround going to be place indefinitely, just to get forgotten about and dropped at some point of time in the future. In this case, it is actually installing all the python support files that import mako and co despite USE=-doctool - just the g-ir-doc-tool doesn't get generated then to actually use these non-working installed python files. Re-opening to handle fully, but dropping bug blockers as workaround is in place |