Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 719252 - >=dev-libs/gobject-introspection-1.62.0 lost USE=test dependency on dev-python/markdown
Summary: >=dev-libs/gobject-introspection-1.62.0 lost USE=test dependency on dev-pytho...
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-04-24 14:52 UTC by Paolo Pedroni
Modified: 2022-06-15 03:21 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Paolo Pedroni 2020-04-24 14:52:12 UTC
gobject-introspection-1.62.0.ebuild and gobject-introspection-1.64.0 have:
DEPEND="${RDEPEND}
        gtk-doc? ( >=dev-util/gtk-doc-1.19
                app-text/docbook-xml-dtd:4.3
                app-text/docbook-xml-dtd:4.5
        )
        sys-devel/bison
        sys-devel/flex
        test? ( x11-libs/cairo[glib] )
"

while both gobject-introspection-1.60.2-r1.ebuild has:
DEPEND="${RDEPEND}
        >=dev-util/gtk-doc-am-1.19
        sys-devel/bison
        sys-devel/flex
        test? (
                x11-libs/cairo[glib]
                $(python_gen_cond_dep '
                        dev-python/markdown[${PYTHON_MULTI_USEDEP}]
                ')
        )
"

This is a regression WRT bug #693408, and thus yielding new test failures on test_docwriter.py tests.
Comment 1 Mart Raudsepp gentoo-dev 2020-04-24 15:52:44 UTC
The dep is already there for USE=doctool (rdepend). If there's a problem, then it's about doctool deps being needed on tests even with -Ddoctool=false being passed to meson configuration
Comment 2 Paolo Pedroni 2020-04-27 06:42:51 UTC
The dep on markdown was added in version 1.60.2-r1 in bug #693408, and it fixed tests with the use case USE="-doctool test". Is it really a problem to add it back to 1.62.0 and 1.64.0?
Comment 3 unhappy-ending 2022-06-13 05:33:36 UTC
This is still an issue in 1.72.0. If you have tests enabled, test phase will fail because markdown can't be found. Can the ebuild at least be updated so that if testing is enabled the right dependency gets pulled in? Or perhaps, skip that test when USE="-doctools" please?
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-06-14 15:12:39 UTC
(In reply to unhappy-ending from comment #3)
> This is still an issue in 1.72.0. If you have tests enabled, test phase will
> fail because markdown can't be found. Can the ebuild at least be updated so
> that if testing is enabled the right dependency gets pulled in? Or perhaps,
> skip that test when USE="-doctools" please?

That doesn't make sense to me.

So:

option('doctool', type: 'feature', value : 'auto',
  description: 'Install g-ir-doc-tool and run related tests'
)

... and https://gitlab.gnome.org/GNOME/gobject-introspection/-/commit/4e1ada2070a2626c82bd510f5165e5557c7d0608 is curious. It implies it's supposed to do the right thing already.

Furthermore, we actually have the markdown dep unconditionally for tests right now anyway?

>                $(python_gen_cond_dep '
>                        dev-python/mako[${PYTHON_USEDEP}]
>                        dev-python/markdown[${PYTHON_USEDEP}]
>                ')
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-06-14 15:14:54 UTC
(In reply to unhappy-ending from comment #3)
> This is still an issue in 1.72.0. If you have tests enabled, test phase will
> fail because markdown can't be found. Can the ebuild at least be updated so
> that if testing is enabled the right dependency gets pulled in? Or perhaps,
> skip that test when USE="-doctools" please?

If you're having an issue, please file a new bug with the full log and emerge --info. It does not appear to be the same issue as this one, as explained above.

It's possible it's something like the doctools stuff doesn't get built but one of the tests still expects it, but I don't see how right now.
Comment 6 unhappy-ending 2022-06-15 03:16:25 UTC
Weird, I've had gobject-introspection on my system and markdown wasn't pulled in when I went to rebuild it, I had to manually do it. I just forcefully (emerge -C) both markdown and gobject-introspection and did a re-emerge and it's pulling in correctly now. Maybe I missed something along the way, likely user error. Sorry :)