Bug 723866

Summary:	=sys-apps/rng-tools-6.10 fails to build on LibreSSL installations
Product:	Gentoo Linux	Reporter:	Reuben Farrelly <reuben-gentoo-bugzilla>
Component:	Current packages	Assignee:	Göktürk Yüksek <gokturk>
Status:	RESOLVED FIXED
Severity:	normal	CC:	base-system, jstein, vit.kasal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	561854

Description Reuben Farrelly 2020-05-19 04:21:13 UTC

A change was made to the ebuild from rng-tools 6.9 to 6.10, whereby OpenSSL became a hard dependency for the package to build:

DEPEND="
 dev-libs/openssl:0=
 ...
"

This is an issue because the rng-tools package does actually appear to build and run succesfully with LibreSSL also.  So the requirement for OpenSSL should be relaxed slightly to also permit the package to build and run on LibreSSL systems.

Comment 1 Göktürk Yüksek archtester

2020-09-25 17:20:07 UTC

OpenSSL did become a hard requirement in 6.10:

  https://github.com/nhorman/rng-tools/compare/v6.9...v6.10#diff-67e997bcfdac55191033d57a16d1408aR134

I don't mind adding libreSSL support for this but I have no libreSSL system to test this on. Can you tell me how you tested it?

Comment 2 Reuben Farrelly 2020-09-28 11:20:46 UTC

I tested this by building on an up-to-date system that has LibreSSL on it instead of OpenSSL. At the time I logged the bug it was with and earlier version of LibreSSL but I've just re-tested now and it also builds fine with the latest LibreSSL-3.2.

The USE flags are:

USE="-jitterentropy -nistbeacon -pkcs11 (-selinux)"

(Note that pkcs11 is not enabled in my build)

The build detects SSL and completes without a problem:

checking pkg-config is at least version 0.9.0... yes
checking for openssl... yes
checking for library containing sysfs_get_mnt_path... -lsysfs

And the resultant binary runs fine too.  I have this running on 5 systems and don't see any issues with any of them.

The ebuild in my local overlay is identical to the one in the main tree except that I've changed the DEPEND reference from openssl to libressl to test.  But the right fix is probably to allow either to satisfy the dependency.

Comment 3 Larry the Git Cow gentoo-dev

2020-10-05 18:27:10 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=63c183a960752150b42686ff09604ff253542988

commit 63c183a960752150b42686ff09604ff253542988
Author:     Göktürk Yüksek <gokturk@gentoo.org>
AuthorDate: 2020-10-05 18:26:34 +0000
Commit:     Göktürk Yüksek <gokturk@gentoo.org>
CommitDate: 2020-10-05 18:26:34 +0000

    sys-apps/rng-tools: add support for libressl
    
    Closes: https://bugs.gentoo.org/723866
    Package-Manager: Portage-3.0.8, Repoman-3.0.1
    Signed-off-by: Göktürk Yüksek <gokturk@gentoo.org>

 sys-apps/rng-tools/rng-tools-6.10-r1.ebuild | 85 +++++++++++++++++++++++++++++
 1 file changed, 85 insertions(+)