Summary: | dev-qt/qtwebengine: src/3rdparty/chromium/third_party/perfetto/include/perfetto/base/task_runner.h:48:55: error: 'uint32_t' has not been declared | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Duncan <1i5t5.duncan> |
Component: | Current packages | Assignee: | Qt Bug Alias <qt> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | ao, asturm, carlphilippreh, creideiki+gentoo-bugzilla, cyshei, daniel, fturco, himbeere, toralf, xaviermiller |
Priority: | Normal | Keywords: | PATCH |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://bugs.gentoo.org/show_bug.cgi?id=706426 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
emerge --info qtwebengine
failing build log (xz-ed to fit) qtwebengine-5.14.2-gcc-10-build.patch dev-qt-qtwebengine-5.15.0_rc2:20200514-123356.log qtwebengine-5.14.2-gcc-10-build.patch |
Created attachment 637132 [details]
failing build log (xz-ed to fit)
Same issue also exists in the non-overlay 5.14.2 with GCC 10 as well. While using jumbo build, I also see a failure on 5.14.2 with GCC. When trying to compile with CC=clang CXX=clang++ it fails in a different position. Yep, this is already fixed upstream [1], and can probably be backported quick-like. 1. https://code.qt.io/cgit/qt/qtwebengine-chromium.git/commit/?h=80-based&id=eaf11e78ea Created attachment 637246 [details, diff]
qtwebengine-5.14.2-gcc-10-build.patch
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/qt.git/commit/?id=a127863585a1407e549afb7e92f8f0ca355cb109 commit a127863585a1407e549afb7e92f8f0ca355cb109 Author: Jimi Huotari <chiitoo@gentoo.org> AuthorDate: 2020-05-10 04:17:21 +0000 Commit: Jimi Huotari <chiitoo@gentoo.org> CommitDate: 2020-05-10 04:46:43 +0000 dev-qt/qtwebengine: fix build with GCC-10 Bug: https://bugs.gentoo.org/721876 Package-Manager: Portage-2.3.99, Repoman-2.3.22 Signed-off-by: Jimi Huotari <chiitoo@gentoo.org> .../files/qtwebengine-5.15.0-gcc-10-build.patch | 64 ++++++++++++++++++++++ dev-qt/qtwebengine/qtwebengine-5.15.0_rc.ebuild | 1 + 2 files changed, 65 insertions(+) *** Bug 722220 has been marked as a duplicate of this bug. *** Created attachment 638920 [details]
dev-qt-qtwebengine-5.15.0_rc2:20200514-123356.log
Fix is not enough for 5.15.0_rc2.
*** Bug 723010 has been marked as a duplicate of this bug. *** (In reply to Andreas Sturmlechner from comment #8) > Created attachment 638920 [details] > dev-qt-qtwebengine-5.15.0_rc2:20200514-123356.log > > Fix is not enough for 5.15.0_rc2. https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/300434 Created attachment 639068 [details, diff]
qtwebengine-5.14.2-gcc-10-build.patch
Now with more <string> include.
Thanks, fixed in 63b27c3c. task_runner.h is patched, still src/3rdparty/chromium/third_party/webrtc/modules/video_coding/decoding_state.cc is not patched: In file included from ../../../../qtwebengine-everywhere-src-5.14.2/src/3rdparty/chromium/third_party/webrtc/modules/video_coding/decoding_state.cc:11: ../../../../qtwebengine-everywhere-src-5.14.2/src/3rdparty/chromium/third_party/webrtc/modules/video_coding/decoding_state.h:29:16: error: ‘uint16_t’ does not name a type 29 | static const uint16_t kNumRefBits = 7; | ^~~~~~~~ @Pavel Volkov probably you need to add '#include <stdint.h>' to src/3rdparty/chromium/third_party/webrtc/modules/video_coding/decoding_state.h Yes, replacing 'qtwebengine-5.14.2-gcc-10-{1,2}.patch' with the one I attached here should work. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=459a1fb8aa74947e214661bbd5cbebcaed8ece17 commit 459a1fb8aa74947e214661bbd5cbebcaed8ece17 Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2020-05-17 08:16:10 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2020-05-17 08:16:54 +0000 dev-qt/qtwebengine: Update gcc-10.patch Additionally includes patch to decoding_state.h. Thanks-to: Jimi Huotari <chiitoo@gentoo.org> Bug: https://bugs.gentoo.org/721876 Package-Manager: Portage-2.3.99, Repoman-2.3.22 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> .../files/qtwebengine-5.14.2-gcc-10-2.patch | 27 ---------------- ...-10-1.patch => qtwebengine-5.14.2-gcc-10.patch} | 37 ++++++++++++++++++---- dev-qt/qtwebengine/qtwebengine-5.14.2.ebuild | 4 +-- 3 files changed, 33 insertions(+), 35 deletions(-) |
Created attachment 637064 [details] emerge --info qtwebengine After merging gcc-10.1.0 and eselecting to it today, I continued with my usual updates, including the new qt 5.15.0_rc from the qt overlay. All of the new qt packages (well, that I have installed) merged fine except for qtwebengine-5.15.0_rc. After eselecting back to gcc-9.3.0 it seems to be building fine (still building but way past the problem with gcc-10.1 and the betas built with gcc-9.3 were installed previously), so the problem appears to be triggered by gcc-10.1.0. USE="alsa bindist jumbo-build system-ffmpeg system-icu widgets -debug -designer -geolocation -kerberos -pulseaudio -test" FAILED: obj/third_party/perfetto/src/base/base/virtual_destructors.o [...] In file included from ../../../../qtwebengine-everywhere-src-5.15.0-rc/src/3rdparty/chromium/third_party/perfetto/src/base/virtual_destructors.cc:17: ../../../../qtwebengine-everywhere-src-5.15.0-rc/src/3rdparty/chromium/third_party/perfetto/include/perfetto/base/task_runner.h:48:55: error: 'uint32_t' has not been declared 48 | virtual void PostDelayedTask(std::function<void()>, uint32_t delay_ms) = 0; | ^~~~~~~~ [...] FAILED: obj/third_party/perfetto/src/base/base/unix_task_runner.o [...] In file included from ../../../../qtwebengine-everywhere-src-5.15.0-rc/src/3rdparty/chromium/third_party/perfetto/include/perfetto/ext/base/unix_task_runner.h:21, from ../../../../qtwebengine-everywhere-src-5.15.0-rc/src/3rdparty/chromium/third_party/perfetto/src/base/unix_task_runner.cc:20: ../../../../qtwebengine-everywhere-src-5.15.0-rc/src/3rdparty/chromium/third_party/perfetto/include/perfetto/base/task_runner.h:48:55: error: 'uint32_t' has not been declared 48 | virtual void PostDelayedTask(std::function<void()>, uint32_t delay_ms) = 0; | ^~~~~~~~ In file included from ../../../../qtwebengine-everywhere-src-5.15.0-rc/src/3rdparty/chromium/third_party/perfetto/src/base/unix_task_runner.cc:20: ../../../../qtwebengine-everywhere-src-5.15.0-rc/src/3rdparty/chromium/third_party/perfetto/include/perfetto/ext/base/unix_task_runner.h:69:8: error: 'void perfetto::base::UnixTaskRunner::PostDelayedTask(std::function<void()>, uint32_t)' marked 'override', but does not override 69 | void PostDelayedTask(std::function<void()>, uint32_t delay_ms) override; | ^~~~~~~~~~~~~~~ [...] ninja: build stopped: subcommand failed. make[3]: *** [Makefile.gn_run:543: run_ninja] Error 1 make[3]: Leaving directory '/tmp/portage/dev-qt/qtwebengine-5.15.0_rc/work/qtwebengine-everywhere-src-5.15.0-rc_build/src/core' make[2]: *** [Makefile:82: sub-gn_run-pro-make_first] Error 2 emerge --info qtwebengine attached, full build failure log to be attached.