Bug 721374 – media-libs/libv4l-1.18.1 configure error when /bin/sh != /bin/bash

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Matt Whitlock 2020-05-07 06:48:21 UTC]

libv4l's configure.ac contains a Bashism (use of == operator with test built-in). Thus, configure throws an error when /bin/sh is not Bash. This doesn't cause the build to fail outright, but it may be causing misdetection of features.

AM_CONDITIONAL([WITH_GCONV],        [test x$enable_gconv = xyes -a x$enable_shared == xyes -a x$with_gconvdir != x -a -f $with_gconvdir/gconv-modules])

/var/tmp/portage/media-libs/libv4l-1.18.1/work/v4l-utils-1.18.1/configure: 23600: test: xyes: unexpected operator

Suggest setting CONFIG_SHELL=/bin/bash when running configure. The "unexpected operator" message above is not present when CONFIG_SHELL=/bin/bash.

[Comment 1 Lars Wendler (Polynomial-C) (RETIRED) 2020-05-07 07:23:49 UTC]

Patch sent to upstream (see URL)...

[Comment 2 Larry the Git Cow 2020-08-23 16:42:41 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=205e228434c0f9ff2e6156942a1ee8f8f56129fa

commit 205e228434c0f9ff2e6156942a1ee8f8f56129fa
Author:     James Le Cuirot <[e-mail]>
AuthorDate: 2020-08-23 16:37:15 +0000
Commit:     James Le Cuirot <[e-mail]>
CommitDate: 2020-08-23 16:42:18 +0000

    media-tv/v4l-utils: Bump to 1.20.0, fix some automagics
    
    The automagic libudev dependency has now been dealt with via a patch
    and udev USE flag. Among other things, this library is needed for the
    DVB utilities so a dvb USE flag has also been added with a
    corresponding dependency on libv4l[dvb]. There may be more automagics
    but I haven't checked yet.
    
    Bug: https://bugs.gentoo.org/691066
    Bug: https://bugs.gentoo.org/721374
    Package-Manager: Portage-3.0.4, Repoman-3.0.1
    Signed-off-by: James Le Cuirot <[e-mail]>

 media-tv/v4l-utils/Manifest                        |  1 +
 .../files/v4l-utils-1.20.0-automagic.patch         | 52 +++++++++++++
 media-tv/v4l-utils/v4l-utils-1.20.0.ebuild         | 89 ++++++++++++++++++++++
 3 files changed, 142 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=293838bf393bf79cd833e435f4bc0f75399726ca

commit 293838bf393bf79cd833e435f4bc0f75399726ca
Author:     James Le Cuirot <[e-mail]>
AuthorDate: 2020-08-23 16:31:22 +0000
Commit:     James Le Cuirot <[e-mail]>
CommitDate: 2020-08-23 16:42:15 +0000

    media-libs/libv4l: Bump to 1.20.0, fix automagics
    
    configure reportedly has some automagic dependencies but only libudev
    makes any difference here and it's only used to build libdvbv5. There
    is already an option for that.
    
    Bug: https://bugs.gentoo.org/691066
    Bug: https://bugs.gentoo.org/721374
    Package-Manager: Portage-3.0.4, Repoman-3.0.1
    Signed-off-by: James Le Cuirot <[e-mail]>

 media-libs/libv4l/Manifest                         |  1 +
 .../libv4l/files/libv4l-1.20.0-automagic.patch     | 52 +++++++++++++++
 media-libs/libv4l/libv4l-1.20.0.ebuild             | 78 ++++++++++++++++++++++
 3 files changed, 131 insertions(+)