Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 718332

Summary: media-gfx/img2pdf: need py3.7, 3.8 port
Product: Gentoo Linux Reporter: Michał Górny <mgorny>
Component: Current packagesAssignee: Diogo Pereira <sir.suriv>
Status: RESOLVED FIXED    
Severity: normal CC: fturco, proxy-maint
Priority: Normal Keywords: PullRequest
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/gentoo/pull/15459
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 695996    

Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-04-19 14:34:44 UTC
The packages are stuck on py3.6 which means they will be pain once we switch to 3.7.  Please test them on 3.7 *and* 3.8 (so we don't to revisit this in a few months), and update PYTHON_COMPAT appropriately.  If it doesn't work, please either fix it, remove Python or issue last rites.  Please consider this urgent.
Comment 1 Diogo Pereira 2020-04-19 22:22:59 UTC
The tests require dev-python/pdfrw which only supports Python 3.6 at the moment. Other than that, the package works with Python 3.7.

We can wait for pdfrw to support Python 3.7 or just drop the tests. What do you suggest?
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-04-20 07:42:37 UTC
(In reply to Diogo Pereira from comment #1)
> The tests require dev-python/pdfrw which only supports Python 3.6 at the
> moment. Other than that, the package works with Python 3.7.
> 
> We can wait for pdfrw to support Python 3.7

Done.  However, the package is dead and crappy, and the code is not wholly py3.7 compliant, so it may fail depending on what you use.
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-04-20 10:31:43 UTC
I've asked upstream if there's any value in pdfrw support:

https://gitlab.mister-muffin.de/josch/img2pdf/issues/74
Comment 4 Larry the Git Cow gentoo-dev 2020-04-23 06:01:07 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3eaae3a768cbe49e018aa61ef4148a0251d0c8ca

commit 3eaae3a768cbe49e018aa61ef4148a0251d0c8ca
Author:     Diogo Pereira <sir.suriv@gmail.com>
AuthorDate: 2020-04-21 23:21:21 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2020-04-23 06:00:56 +0000

    media-gfx/img2pdf: bump to 0.3.4
    
    - Support Python 3.7 and 3.8
    - Fix DISTUTILS_USE_SETUPTOOLS QA notice
    - Use distutils_enable_tests
    
    Closes: https://bugs.gentoo.org/711596
    Closes: https://bugs.gentoo.org/718332
    Signed-off-by: Diogo Pereira <sir.suriv@gmail.com>
    Package-Manager: Portage-2.3.89, Repoman-2.3.20
    Closes: https://github.com/gentoo/gentoo/pull/15459
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 media-gfx/img2pdf/Manifest             |  1 +
 media-gfx/img2pdf/img2pdf-0.3.4.ebuild | 25 +++++++++++++++++++++++++
 2 files changed, 26 insertions(+)