Summary: | net-wireless/rtl_433: EAPI-8 bump, port to cmake.eclass | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | John (EBo) David <ebo> |
Component: | Current packages | Assignee: | Gentoo Radio project <radio> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | jstein, stefantalpalaru |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://archives.gentoo.org/gentoo-dev/message/3aa1a3aeebad353a7cefcb86a8101943 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 770247, 834110 | ||
Attachments: |
rtl_433-20.02.ebuld
obligatory emerge info |
Created attachment 633622 [details]
obligatory emerge info
Thank you for your contribution. I had a short look on the ebuild. Here a few ideas: * We always try to use the latest EAPI, please bump to EAPI=7 * A bot can look for additional mistakes, if you upload a PR via github what repo do you want me to clone/fork to make the PR? rtl_433-21.05 available in my overlay: https://github.com/stefantalpalaru/gentoo-overlay In the year 2021 we don't bump packages still using cmake-utils.eclass. Small excerpt of cmake.eclass changes: - Drop all pre-EAPI-7 compatibility - Drop CMAKE_MIN_VERSION - Drop CMAKE_REMOVE_MODULES - Array support for CMAKE_REMOVE_MODULES_LIST - Drop _cmake_generator_to_use() - Rename cmake-utils_src_make() -> cmake_build() - Drop _cmake_ninja_src_make and _cmake_emake_src_make, move into cmake_build Disappointing to see this bug be ignored and have an EAPI-5 bump in 2021. commit 8e180218fb867ae3103a3887847ae7ef3173f569 Author: Rick Farina <zerochaos@gentoo.org> Date: Fri Jun 18 13:08:19 2021 -0400 net-wireless/rtl_433: bump Package-Manager: Portage-3.0.19, Repoman-3.0.3 @Andreas Sorry. I completely dropped the ball on putting in the PR. (In reply to John (EBo) David from comment #7) > @Andreas Sorry. I completely dropped the ball on putting in the PR. Still interested? The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cb5da522e19f629f35342c5e7b613c6aedcb42c7 commit cb5da522e19f629f35342c5e7b613c6aedcb42c7 Author: Rick Farina <zerochaos@gentoo.org> AuthorDate: 2022-03-16 20:48:04 +0000 Commit: Rick Farina <zerochaos@gentoo.org> CommitDate: 2022-03-16 20:54:29 +0000 net-wireless/rtl_433: eapi and eclass bump Signed-off-by: Rick Farina <zerochaos@gentoo.org> Closes: https://bugs.gentoo.org/718082 net-wireless/rtl_433/Manifest | 2 +- .../{rtl_433-21.05.ebuild => rtl_433-21.12.ebuild} | 24 +++++++++++----------- net-wireless/rtl_433/rtl_433-9999.ebuild | 19 +++++++++-------- 3 files changed, 24 insertions(+), 21 deletions(-) |
Created attachment 633620 [details] rtl_433-20.02.ebuld I have updated the ebuild to work with the latest released version (20.02).