Summary: | =app-portage/portage-utils-0.82: qlop -r misses some packages that are currently merged when running as non-root user in the portage group | ||
---|---|---|---|
Product: | Portage Development | Reporter: | Till Schäfer <till2.schaefer> |
Component: | Tools | Assignee: | Fabian Groffen <grobian> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | tail of emerge.log |
Description
Till Schäfer
2019-12-04 15:21:02 UTC
Created attachment 598416 [details]
tail of emerge.log
is this during the entire process of merging, or only near the end of it, e.g. when it's cleaning up? the firefox merge was still going for another half an hour or so. ETA of genlop is heavily biased by very old firefox releases, that took only a few minutes to merge. and qlop was ran as root? no, as a user in to the portage group. Ok, that probably is the reason why then. yes, you are right. It is always reproducible with a non-root user in the portage group. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/portage-utils.git/commit/?id=1e5b2c8d3fb58335990e411af98498f249b54980 commit 1e5b2c8d3fb58335990e411af98498f249b54980 Author: Fabian Groffen <grobian@gentoo.org> AuthorDate: 2019-12-27 20:38:44 +0000 Commit: Fabian Groffen <grobian@gentoo.org> CommitDate: 2019-12-27 20:38:44 +0000 qlop: some changes to -r (running) mode - warn when qlop needs to defer to log heuristics (#701968) - print running packages most recent first - suppress identical running packages (#701392) - ignore batches in emerge.log that appear to be backwards in time Bug: https://bugs.gentoo.org/701968 Bug: https://bugs.gentoo.org/701392 Signed-off-by: Fabian Groffen <grobian@gentoo.org> qlop.c | 50 +++++++++++++++++++++++++++++++++++++++++++------- tests/qlop/list01.good | 2 +- tests/qlop/list10.good | 4 ++-- tests/qlop/sync.log | 12 ++++++------ 4 files changed, 52 insertions(+), 16 deletions(-) The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ccbfbff3ffb51a9e7783458c9dad3e6d2cb49e29 commit ccbfbff3ffb51a9e7783458c9dad3e6d2cb49e29 Author: Fabian Groffen <grobian@gentoo.org> AuthorDate: 2019-12-28 09:42:05 +0000 Commit: Fabian Groffen <grobian@gentoo.org> CommitDate: 2019-12-28 09:42:23 +0000 app-portage/portage-utils-0.83: version bump with bugfixes Drop overshadowed testing versions. Closes: https://bugs.gentoo.org/701968 Closes: https://bugs.gentoo.org/701470 Bug: https://bugs.gentoo.org/701402 Closes: https://bugs.gentoo.org/701392 Closes: https://bugs.gentoo.org/701386 Closes: https://bugs.gentoo.org/700850 Closes: https://bugs.gentoo.org/699558 Package-Manager: Portage-2.3.79, Repoman-2.3.16 Signed-off-by: Fabian Groffen <grobian@gentoo.org> app-portage/portage-utils/Manifest | 3 +- .../portage-utils/portage-utils-0.74-r1.ebuild | 38 ---------- .../portage-utils/portage-utils-0.81.ebuild | 87 ---------------------- ...utils-0.82.ebuild => portage-utils-0.83.ebuild} | 0 4 files changed, 1 insertion(+), 127 deletions(-) The current solution seems suboptimal to me, since it was possible to run qlop -r with pre-0.80 version and a portage group user without any workarounds. AFAIK this versions also relied on watching the current running processes. The same applies to genlop. The current workaround re-introduces many of the fixed problems in the from the previous versions. Thus, maybe there is a better solution. PS: The error message contains a small typo: "lop: ..." (missing q). Feel free to close the bug again, if I am wrong with something. The "lop" thing is because the applet is called "lop", but I don't like it either. What genlop and older portage-utils do, is to look at the process names, and match sandbox. Sandbox has a nifty feature to embed the package name in its process name when it runs. This one is extracted and that's what's being used. There's some things not nice about that approach: 1) it assumes sandbox is in use, and that sandbox remains doing what it does, while there have been some people voicing the opinion that sandbox is outdated and should go. Its performance isn't too good in some aspects either. 2) an ongoing "emerge" is only visible when the sandbox stage runs, e.g. the compile and install. While this is the majority, it isn't the full thing. FEATURES=-sandbox essentially numbs the sandbox detection approach. However, since /proc/x/cmdline is world-readable, qlop could try to scan for sandbox there, and use matches it finds, for the majority of people will still have sandbox for a while. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/portage-utils.git/commit/?id=7cdf692beb93c596b4bf4f5f7b5bb8bcc69a27ea commit 7cdf692beb93c596b4bf4f5f7b5bb8bcc69a27ea Author: Fabian Groffen <grobian@gentoo.org> AuthorDate: 2019-12-29 09:54:28 +0000 Commit: Fabian Groffen <grobian@gentoo.org> CommitDate: 2019-12-29 09:54:28 +0000 q: improve applet searching somewhat, change warn app name - use a single loop iteration to match an applet - set full name of applet (qlop iso lop) in argv0 for warn() to match the running command - use name of aliased applet when invoked by an alias (belongs -> qfile) Bug: https://bugs.gentoo.org/701968 Signed-off-by: Fabian Groffen <grobian@gentoo.org> applets.h | 1 - q.c | 37 +++++++++++++++++++++++++++---------- 2 files changed, 27 insertions(+), 11 deletions(-) The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1278e75ff758df9e3a7f11d57d36dc378461fe2e commit 1278e75ff758df9e3a7f11d57d36dc378461fe2e Author: Fabian Groffen <grobian@gentoo.org> AuthorDate: 2020-10-04 20:14:05 +0000 Commit: Fabian Groffen <grobian@gentoo.org> CommitDate: 2020-10-04 20:14:05 +0000 app-portage/portage-utils-0.90: version bump for qlop fixes Closes: https://bugs.gentoo.org/745798 Closes: https://bugs.gentoo.org/731122 Closes: https://bugs.gentoo.org/713536 Closes: https://bugs.gentoo.org/705748 Closes: https://bugs.gentoo.org/701968 Package-Manager: Portage-3.0.4, Repoman-3.0.1 Signed-off-by: Fabian Groffen <grobian@gentoo.org> app-portage/portage-utils/Manifest | 2 +- ...portage-utils-0.88.ebuild => portage-utils-0.90.ebuild} | 14 -------------- 2 files changed, 1 insertion(+), 15 deletions(-) |