| Summary: | >=dev-db/pgadmin4-4.13 - add python 3.7 support | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | José de Paula Rodrigues <espinafre> |
| Component: | Current packages | Assignee: | PgSQL Bugs <pgsql-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | asturm, espinafre, StormByte |
| Priority: | Normal | Keywords: | EBUILD, PullRequest |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://github.com/gentoo/gentoo/pull/13809 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 695996 | ||
| Attachments: |
pgadmin4-4.13-r1 with Python 3.7
pgadmin4-4.16.ebuild against Python 3.8 (needs companion patch) companion patch to build pgadmin4 against Python 3.8+ |
||
|
Description
José de Paula Rodrigues
2019-10-18 03:59:07 UTC
Created attachment 593116 [details]
pgadmin4-4.13-r1 with Python 3.7
dev-python/Flask-Script does not support 3.7, which is needed by dev-python/Flask-Migrate. Until Flask-Script is updated for 3.7 or Flask-Migrate drops that requirement, dev-db/pgadmin4 can't yet support 3.7. (In reply to Aaron W. Swenson from comment #2) > dev-python/Flask-Script does not support 3.7, which is needed by > dev-python/Flask-Migrate. > > Until Flask-Script is updated for 3.7 or Flask-Migrate drops that > requirement, dev-db/pgadmin4 can't yet support 3.7. It seems that flask-script is not needed anymore: I modified the ebuild to allow python3_7 and also some of other flask* deps and it compiled successfully, yet flask-script was not pulled in as This is the list of dependencies to be updated to allow compile against python 3.7: (all inside dev-python category) flask-babelex flask-gravatar flask-login flask-mail flask-migrate flask-paranoid flask-principal flask-security flask-wtf speaklater sshtunnel And also app-text/htmlmin I have successfully built dev-db/pgadmin4-4.15 with PYTHON_TARGETS="python3_7" But can not build neither 4.13 nor 4.15 with PYTHON_TARGETS="python3_8" Sorry for off-topic The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=beb7a40f168eb080f7892ddc269167e928e87cad commit beb7a40f168eb080f7892ddc269167e928e87cad Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2019-11-30 12:25:44 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2019-12-01 19:25:05 +0000 dev-db/pgadmin4: python3_7 Bug: https://bugs.gentoo.org/697958 Package-Manager: Portage-2.3.80, Repoman-2.3.19 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> dev-db/pgadmin4/pgadmin4-4.13.ebuild | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) I've convinced pgAdmin4 to build and run against Python 3.8; in the process, I've bumped it to pgadmin4-4.16 (released by upstream in 2019-12-12). For that, we need a little patch so qmake can correctly add the Python ldflags (python3-config behavior changed with Python 3.8: https://docs.python.org/3/whatsnew/3.8.html#debug-build-uses-the-same-abi-as-release-build , https://bugs.python.org/issue36721 ). I didn't test against <=dev-lang/python-3.7, sorry. It should work nevertheless. Created attachment 599316 [details]
pgadmin4-4.16.ebuild against Python 3.8 (needs companion patch)
Created attachment 599318 [details, diff]
companion patch to build pgadmin4 against Python 3.8+
Patch needed so that qmake can link against Python 3.8 libraries due to changes in python3-config.
|
