Bug 697476 – Mask 'fam' USE flag for net-fs/samba in profiles/default/linux/package.use.mask and remove from profiles/targets/desktop/make.defaults

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Peter Levine 2019-10-11 05:33:38 UTC]

Both packages that could satisfy virtual/fam, app-admin/gamin and app-admin/fam, are both unmaintained and should eventually be removed. Looking at samba's source, it appears that, similar to kde-frameworks/kcoreaddons and =dev-libs/glib-2* which already mask fam in linux, samba prefers inotify to fam.


From https://github.com/samba-team/samba/blob/ab232ca77f8f08879d99f88cfcd554500717075e/source3/wscript#L143:
>     if host_os.rfind('sunos') == -1:
>         conf.CHECK_HEADERS('sys/inotify.h')
>         if conf.env.HAVE_SYS_INOTIFY_H:
>            conf.DEFINE('HAVE_INOTIFY', 1)
When not on SunOS, if sys/inotify.h exists and defines HAVE_SYS_INOTIFY_H, the build defines HAVE_INOTIFY.

From https://github.com/samba-team/samba/blob/c1e649fd473885c0cb779344fc7089a245c7b17d/source3/smbd/server.c#L343:
> #ifdef HAVE_INOTIFY
> 		if (lp_parm_bool(-1, "notify", "inotify", true)) {
> 			sys_notify_watch = inotify_watch;
> 		}
> #endif
> 
> #ifdef HAVE_FAM
> 		if (lp_parm_bool(-1, "notify", "fam",
> 				 (sys_notify_watch == NULL))) {
> 			sys_notify_watch = fam_watch;
> 		}
> #endif
Assuming both HAVE_INOTIFY and HAVE_FAM are defined at compile-time, it will prefer inotify at runtime.
There appears to be no reference to fam in the source4/ directory (i.e., samba4).

Beyond those packages that already mask the fam USE flag in Linux, I don't see any desktop-oriented packages that would depend on virtual/fam, dev-libs/libgamin, app-admin/fam, app-admin/gam-server, or app-admin/gamin, I believe it shouldn't be default-enabled for desktop profiles.

Reproducible: Always

[Comment 1 Larry the Git Cow 2019-10-15 13:27:25 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7e8c8035ec39f2be7425d3bac093c428dd9a1246

commit 7e8c8035ec39f2be7425d3bac093c428dd9a1246
Author:     Peter Levine <[e-mail]>
AuthorDate: 2019-10-15 13:26:13 +0000
Commit:     Lars Wendler <[e-mail]>
CommitDate: 2019-10-15 13:27:19 +0000

    default/linux/package.use.mask: Mask fam for net-fs/samba
    
    Similar to kde-frameworks/kcoreaddons and =dev-libs/glib-2*, net-fs/samba
    prefers inotify.
    
    Bug: https://bugs.gentoo.org/697476
    Package-Manager: Portage-2.3.76
    Signed-off-by: Peter Levine <[e-mail]>
    Signed-off-by: Lars Wendler <[e-mail]>

 profiles/default/linux/package.use.mask | 5 +++++
 1 file changed, 5 insertions(+)

[Comment 2 Lars Wendler (Polynomial-C) (RETIRED) 2019-10-15 13:29:52 UTC]

I have only pushed the samba part of your commits as I do not want to mess with profile settings. 
Please try to get in touch with a Gentoo developer that has some experience with profiles for your other commit.

[Comment 3 Larry the Git Cow 2020-01-09 12:56:06 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fedd97b17389635d1375276cb670ec60f238860d

commit fedd97b17389635d1375276cb670ec60f238860d
Author:     Ben Kohler <[e-mail]>
AuthorDate: 2020-01-09 12:53:20 +0000
Commit:     Ben Kohler <[e-mail]>
CommitDate: 2020-01-09 12:55:52 +0000

    profiles: remove fam from desktop profiles & unmask on glib
    
    Closes: https://bugs.gentoo.org/657694
    Closes: https://bugs.gentoo.org/697476
    
    Signed-off-by: Ben Kohler <[e-mail]>

 profiles/default/linux/package.use.mask | 4 ----
 profiles/targets/desktop/make.defaults  | 2 +-
 2 files changed, 1 insertion(+), 5 deletions(-)