Summary: | dev-libs/aws-sdk-cpp - euses reports format error in USE descriptions | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Bob Johnson <bob> |
Component: | Current packages | Assignee: | Sven Eden <sven.eden> |
Status: | RESOLVED FIXED | ||
Severity: | QA | CC: | juippis, proxy-maint, sven.eden |
Priority: | Normal | Keywords: | PullRequest |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://github.com/gentoo/gentoo/pull/13030 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Bob Johnson
2019-09-23 16:08:03 UTC
https://projects.gentoo.org/pms/latest/pms.html#x1-350004.4.3 prescribes USE flag descriptions as line-based, and metadata.xml for the dev-libs/aws-sdk-cpp does not adhere to that requirement. Sven, see the PMS requirement about metadata USE length above before fixing it. (In reply to Jeroen Roovers from comment #1) > https://projects.gentoo.org/pms/latest/pms.html#x1-350004.4.3 prescribes USE > flag descriptions as line-based, and metadata.xml for the > dev-libs/aws-sdk-cpp does not adhere to that requirement. Well, the part you linked to says: "It is a line-based file with the standard rules for comments and blank lines." There is no hint about the length, which is the problem here. app-portage/ufed hit the same problem: The line is too long. (Yes, that USE flag is a one-liner in use.local.desc, so it is legal according to the PMS.) But apart from the programs having to simply cut overly long lines, there is nothing wrong with the metadata.xml. There is no rule about a maximum line length, and every content of any tag can have multiple lines. The metadata.xml in question follows GLEP-68: https://www.gentoo.org/glep/glep-0068.html ; which explicitly allows multi-line text data. "repoman full" is also absolutely happy with my metadata.xml file, and "equery u" renders all flags quite nicely. Before you get mad at me: I will shorten it. I think for those modules it is completely in order to have only their names listed. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4a7621add86917245ae0e0e40ca7110894428a94 commit 4a7621add86917245ae0e0e40ca7110894428a94 Author: Sven Eden <yamakuzure@gmx.net> AuthorDate: 2019-09-24 18:15:54 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2019-09-25 02:58:30 +0000 dev-libs/aws-sdk-cpp: Shorten the 'other' USE flag description Unfortunately that description is way too long. It has over 5k characters, which is too much, at least for app-portage/ufed and app-portage/euses. This commit throws away the lengthy description of each module and replaces them with a mere list of the modules. As these are supposed to be rarely used modules anyway, this shouldn't be a problem. If any of the modules is requested to get its own USE flag, we can re-add its proper description. Bug: https://bugs.gentoo.org/695262 Bug: https://bugs.gentoo.org/695462 Package-Manager: Portage-2.3.76, Repoman-2.3.17 Signed-off-by: Sven Eden <yamakuzure@gmx.net> Closes: https://github.com/gentoo/gentoo/pull/13030 Signed-off-by: Joonas Niilola <juippis@gentoo.org> dev-libs/aws-sdk-cpp/metadata.xml | 76 ++++----------------------------------- 1 file changed, 6 insertions(+), 70 deletions(-) So, the offending USE flag was shortened and the problem should go away. Please note: This is a workaround. The real bug here is euses not checking its input correctly. It is the same problem that app-portage/ufed had, which I fixed. While this bug is now RESOLVED/FIXED, euses should be fixed, too. (But that's, of course, just my opinion. ;-) ) |