| Summary: | [mozilla overlay] mail-client/thunderbird-68.0-r1: Missing file(s): bin/defaults/pref/all-gentoo.js with PGO builds | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Perfect Gentleman <perfect007gentleman> |
| Component: | Overlays | Assignee: | Mozilla Gentoo Team <mozilla> |
| Status: | RESOLVED TEST-REQUEST | ||
| Severity: | normal | CC: | alex.iris.parker, chutzpah, perfect007gentleman |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
build.log.xz
unbreak pgo builds Patch fixes freezing during profile generation phase |
||
|
Description
Perfect Gentleman
2019-08-31 05:29:07 UTC
Sat Aug 31 10:52 anarchy@bull thunderbird $ emerge thunderbird Calculating dependencies... done! >>> Verifying ebuild manifests >>> Running pre-merge checks for mail-client/thunderbird-68.0-r1 * Checking for at least 4 GiB disk space at "/var/tmp/portage/mail-client/thunderbird-68.0-r1/temp" ... [ ok ] >>> Emerging (1 of 1) mail-client/thunderbird-68.0-r1::mozilla >>> Installing (1 of 1) mail-client/thunderbird-68.0-r1::mozilla >>> Jobs: 1 of 1 complete Load avg: 1.80, 2.00, 2.69 * Messages for package mail-client/thunderbird-68.0-r1: * You are enabling official branding. You may not redistribute this build * to any users on your network or the internet. Doing so puts yourself into * a legal problem with Mozilla Foundation. * You can disable it by emerging thunderbird _with_ the bindist USE-flag. * User patches applied. >>> Auto-cleaning packages... >>> No outdated packages were found on your system. * GNU info directory index is up-to-date. Sat Aug 31 11:31 anarchy@bull thunderbird Created attachment 588608 [details, diff]
unbreak pgo builds
If you would please test and let me know. I do not use PGO or LTO builds hense I am not seeing the failure. If the over sight on my upgrade is fixed with this patch, I will re-add to the overlay and get tb-68 moved into the tree.
Feel free to reopen if you are still having issues. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e3442ec85f155852d3e0474dcdbe838d94852b52 commit e3442ec85f155852d3e0474dcdbe838d94852b52 Author: Thomas Deutschmann <whissi@gentoo.org> AuthorDate: 2019-09-01 23:54:54 +0000 Commit: Thomas Deutschmann <whissi@gentoo.org> CommitDate: 2019-09-01 23:54:54 +0000 profiles: base: Add mail-client/thunderbird[pgo] to package.use.mask Bug: https://bugs.gentoo.org/693160 Signed-off-by: Thomas Deutschmann <whissi@gentoo.org> profiles/base/package.use.mask | 4 ++++ 1 file changed, 4 insertions(+) I'll test it. the bug is gone. but when built with PGO, build system launches default browser for test which after several minutes does nothing, and compiling halts. I unmasked pgo for thunderbird 91.3.0 and it compiles and runs fine. Maybe time to unmask that flag for testing? profiles/base/package.use.mask: # Thomas Deutschmann <whissi88@gentoo.org> (2019-09-02) # PGO not yet supported for comm-central, bug #693160 >=mail-client/thunderbird-68 pgo (In reply to Alexandra Parker from comment #7) > I unmasked pgo for thunderbird 91.3.0 and it compiles and runs fine. Maybe > time to unmask that flag for testing? > > profiles/base/package.use.mask: > > # Thomas Deutschmann <whissi88@gentoo.org> (2019-09-02) > # PGO not yet supported for comm-central, bug #693160 > >=mail-client/thunderbird-68 pgo It hangs for me, especially with gcc (didn't get to clang yet). Do you use clang or gcc? I guess it needs some patches that have landed to firefox already. Created attachment 750246 [details, diff]
Patch fixes freezing during profile generation phase
(In reply to Joonas Niilola from comment #8) > (In reply to Alexandra Parker from comment #7) > > I unmasked pgo for thunderbird 91.3.0 and it compiles and runs fine. Maybe > > time to unmask that flag for testing? > > > > profiles/base/package.use.mask: > > > > # Thomas Deutschmann <whissi88@gentoo.org> (2019-09-02) > > # PGO not yet supported for comm-central, bug #693160 > > >=mail-client/thunderbird-68 pgo > > It hangs for me, especially with gcc (didn't get to clang yet). Do you use > clang or gcc? > > I guess it needs some patches that have landed to firefox already. I used clang... I think the Firefox ebuild only allows pgo with clang, too, right? (In reply to Alexandra Parker from comment #10) > > I used clang... I think the Firefox ebuild only allows pgo with clang, too, > right? It works with both now. There was a moment when it only worked with clang. (In reply to Perfect Gentleman from comment #9) > Created attachment 750246 [details, diff] [details, diff] > Patch fixes freezing during profile generation phase That doesn't look very legit :P Overall I think we came to a conclusion that upstream currently does not enable pgo builds, so so shouldn't we. We'll end up hunting patches from release to another if upstream doesn't want to fix it. (In reply to Joonas Niilola from comment #11) > (In reply to Perfect Gentleman from comment #9) > > Created attachment 750246 [details, diff] [details, diff] [details, diff] > > Patch fixes freezing during profile generation phase > > That doesn't look very legit :P Overall I think we came to a conclusion that > upstream currently does not enable pgo builds, so so shouldn't we. We'll end > up hunting patches from release to another if upstream doesn't want to fix > it. I created it for older version of TB like in the subject. It didn't worked on previous versions 71 and 78, but it starts working again on 91.3. I don't know what it exactly does. It seems to that it make build system do not wait the completion of on of the tests. I found another problem: thunderbird and firefox both have a build/pgo/profileserver.py that binds to 8888, so you can't build them at the same time |
