Summary: | app-emacs/emacs-common-gentoo-1.6-r2 : .../temp/environment: line 1434: gnome2_icon_savelist: command not found | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Stephan Hartmann (RETIRED) <sultan> |
Component: | Current packages | Assignee: | GNU Emacs project <gnu-emacs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 692410 |
Description
Stephan Hartmann (RETIRED)
![]() >>> Creating Manifest for /home/jer/git/gentoo/app-emacs/emacs-common-gentoo * emacs-common-gentoo-1.6.tar.xz BLAKE2B SHA512 size ;-) ... [ ok ] >>> Unpacking source... >>> Unpacking emacs-common-gentoo-1.6.tar.xz to /home/jer/portage/app-emacs/emacs-common-gentoo-1.6-r2/work >>> Source unpacked in /home/jer/portage/app-emacs/emacs-common-gentoo-1.6-r2/work >>> Preparing source in /home/jer/portage/app-emacs/emacs-common-gentoo-1.6-r2/work/emacs-common-gentoo-1.6 ... >>> Source prepared. >>> Configuring source in /home/jer/portage/app-emacs/emacs-common-gentoo-1.6-r2/work/emacs-common-gentoo-1.6 ... >>> Source configured. >>> Compiling source in /home/jer/portage/app-emacs/emacs-common-gentoo-1.6-r2/work/emacs-common-gentoo-1.6 ... >>> Source compiled. >>> Test phase [not enabled]: app-emacs/emacs-common-gentoo-1.6-r2 >>> Install app-emacs/emacs-common-gentoo-1.6-r2 into /home/jer/portage/app-emacs/emacs-common-gentoo-1.6-r2/image /home/jer/portage/app-emacs/emacs-common-gentoo-1.6-r2/work/emacs-common-gentoo-1.6/icons /home/jer/portage/app-emacs/emacs-common-gentoo-1.6-r2/work/emacs-common-gentoo-1.6 /home/jer/portage/app-emacs/emacs-common-gentoo-1.6-r2/work/emacs-common-gentoo-1.6 /home/jer/portage/app-emacs/emacs-common-gentoo-1.6-r2/temp/environment: line 1434: gnome2_icon_savelist: command not found >>> Completed installing app-emacs/emacs-common-gentoo-1.6-r2 into /home/jer/portage/app-emacs/emacs-common-gentoo-1.6-r2/image * Final size of build directory: 156 KiB * Final size of installed tree: 248 KiB * QA Notice: command not found: * * /home/jer/portage/app-emacs/emacs-common-gentoo-1.6-r2/temp/environment: line 1434: gnome2_icon_savelist: command not found How this one was stabilized without seeing these issues is a miracle. gnome2_icon_savelist is not defined in EAPI=7. Also it should be in pkg_preinst() and is used in src_install(). Later gnome2_icon_cache_update is called, which is also not defined in EAPI=7. I guess gnome2_icon_savelist together with 'inherit' gnome2-utils can be removed. gnome2_icon_cache_update should be replaced with xdg_icon_cache_update. (In reply to Stephan Hartmann from comment #2) > How this one was stabilized without seeing these issues is a miracle. Yes, maintainer's fault (i.e., mine). Looks like I've missed the change in gnome2-utils when bumping the ebuild to EAPI 7. > gnome2_icon_savelist is not defined in EAPI=7. Also it should be in > pkg_preinst() and is used in src_install(). It doesn't really matter in which of these functions it is called, because the function will only affect the environment. In fact, we moved it from preinst to install at some point (and I'm pretty sure that was with an ack from the gnome team): https://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/app-emacs/emacs-common-gentoo/emacs-common-gentoo-1.0.ebuild?hideattic=0&r1=1.12&r2=1.13 The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=66bd2c16de5af5d58a7413ba7cbb89e6b6c2f5aa commit 66bd2c16de5af5d58a7413ba7cbb89e6b6c2f5aa Author: Ulrich Müller <ulm@gentoo.org> AuthorDate: 2019-08-22 12:34:36 +0000 Commit: Ulrich Müller <ulm@gentoo.org> CommitDate: 2019-08-22 12:44:18 +0000 app-emacs/emacs-common-gentoo: Drop gnome2-utils. gnome2_icon_savelist() and gnome2_icon_cache_update() are no longer defined in EAPI 7. Use xdg_icon_cache_update as replacement. Closes: https://bugs.gentoo.org/692520 Reported-by: Stephan Hartmann <stha09@googlemail.com> Package-Manager: Portage-2.3.71, Repoman-2.3.17 Signed-off-by: Ulrich Müller <ulm@gentoo.org> ...mon-gentoo-1.6-r2.ebuild => emacs-common-gentoo-1.6-r3.ebuild} | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) |