| Summary: | dev-util/lsuio: EAPI=7 bump | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Michael Mair-Keimberger (iamnr3) <mmk> |
| Component: | Current packages | Assignee: | Andrew Savchenko <bircoph> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | Keywords: | PATCH, PullRequest |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://github.com/gentoo/gentoo/pull/12070 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | lsuio.patch | ||
|
Description
Michael Mair-Keimberger (iamnr3)
2019-05-21 19:02:01 UTC
Created attachment 577510 [details, diff]
lsuio.patch
git diff for dev-util/lsuio
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cf028e4d6567fb12957c5a54157bfac498ea43dc commit cf028e4d6567fb12957c5a54157bfac498ea43dc Author: Andrew Savchenko <bircoph@gentoo.org> AuthorDate: 2019-11-04 20:44:34 +0000 Commit: Andrew Savchenko <bircoph@gentoo.org> CommitDate: 2019-11-04 20:59:58 +0000 dev-util/lsuio: bump to EAPI 7 Bug: https://bugs.gentoo.org/686500 Closes: https://bugs.gentoo.org/697330 Package-Manager: Portage-2.3.78, Repoman-2.3.17 Signed-off-by: Andrew Savchenko <bircoph@gentoo.org> dev-util/lsuio/files/lsuio-0.2.0-build.patch | 4 ++-- dev-util/lsuio/lsuio-0.2.0-r1.ebuild | 15 +++++++++++++++ 2 files changed, 17 insertions(+), 2 deletions(-) Hi! Thank you for the interest to this package, but you made several mistakes during EAPI 7 bump, so I committed a different fix in cf028e4d6567fb12957c5a54157bfac498ea43dc. What's wrong with you patch? 1) The lsuio-0.2.0-build.patch was dropped. While the package will build without it, a serious QA issue will be present which may result into run-time failures: * QA Notice: Package triggers severe warnings which indicate that it * may exhibit random runtime failures. * lsuio.c:82:17: warning: implicit declaration of function 'uio_mmap_test' [-Wimplicit-function-declaration] Please be careful in future not to drop patches just because a package may be built without them. 2) HOMEPAGE was updated to use https, but SRC_URI doesn't. In this case s/http/https/ doesn't work for SRC_URI, but it is still possible to find a new address. Both issues above are fixed in cf028e4d6567fb12957c5a54157bfac498ea43dc. However, there is a third issue which is not yet fixed, since it doesn't block EAPI 7 bump: update to libuio-0.2.1. Actually lsuio is a subset of a larger project now, containing libuio library, lsuio and rwuio tools: https://sourceforge.net/projects/libuio/files/libuio-0.2.1.tar.bz2/download There are some forks available on github with more patches. So pkgmove will be necessary as well. The whole job is easy, but requires some time and I have difficulty with that right now. So if you are interested in the project, patches are welcome :) |
