Summary: | =sys-apps/portage-2.3.66-r1 prints confusing license list on rejection: sys-kernel/linux-firmware-20190514::gentoo (masked by: || ( ) linux-fw-redistributable license(s)) | ||
---|---|---|---|
Product: | Portage Development | Reporter: | Sergei Trofimovich (RETIRED) <slyfox> |
Component: | Core - Interface (emerge) | Assignee: | Portage team <dev-portage> |
Status: | CONFIRMED --- | ||
Severity: | normal | CC: | mgorny, ulm |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Sergei Trofimovich (RETIRED)
2019-05-21 07:13:22 UTC
ebuild's licence string: LICENSE="GPL-2 GPL-2+ GPL-3 BSD MIT || ( MPL-1.1 GPL-2 ) redistributable? ( linux-fw-redistributable ( BSD-2 BSD BSD-4 ISC MIT no-source-code ) ) unknown-license? ( all-rights-reserved )" With incoming versions of gentoo-kernel-bin, this gets even better: - sys-kernel/gentoo-kernel-bin-6.6.7::gentoo (masked by: || ( ) || ( ) || ( ) || ( ) || ( ) || ( ) || ( ) intel-ucode || ( ) || ( ) || ( ) || ( ) || ( ) linux-fw-redistributable || ( ) license(s)) Seems this goes back to the _getMissingLicenses method added initially here, though it's now the _getMaskedLicenses method of LicenseManager: https://gitweb.gentoo.org/proj/portage.git/commit/?id=ffbff569ac5769449d4f106b7b6beb37db03c0f6 commit ffbff569ac5769449d4f106b7b6beb37db03c0f6 Author: Zac Medico <zmedico@gentoo.org> Date: 2007-03-20 09:52:15 +0000 Implement license visibility filtering for GLEP 23, bug #17367, and bug #152593. svn path=/main/trunk/; revision=6251 The "masked by" message is now generated with this code in a _getmaskingstatus function: missing_licenses = settings._getMissingLicenses(mycpv, metadata) if missing_licenses: allowed_tokens = {"||", "(", ")"} allowed_tokens.update(missing_licenses) license_split = licenses.split() license_split = [x for x in license_split if x in allowed_tokens] |