| Summary: | dev-util/cmake-3.14.3: _cmake_modify-cmakelists is breaking tests | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Thomas Deutschmann (RETIRED) <whissi> |
| Component: | Current packages | Assignee: | Gentoo KDE team <kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | tka |
| Priority: | Normal | Keywords: | PullRequest, TESTFAILURE |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: |
https://bugs.gentoo.org/show_bug.cgi?id=674768 https://bugs.gentoo.org/show_bug.cgi?id=686482 https://github.com/gentoo/gentoo/pull/12385 |
||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | build.log | ||
|
Description
Thomas Deutschmann (RETIRED)
2019-05-18 22:42:19 UTC
I can definitely confirm that disabling _cmake_modify-cmakelists is fixing the tests for me. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/proj/kde.git/commit/?id=e805777440326a241ed04343a995ed0cecddd682 commit e805777440326a241ed04343a995ed0cecddd682 Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2019-05-19 16:15:29 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2019-05-19 16:48:05 +0000 cmake-utils.eclass: _cmake_modify-cmakelists: Fix CMAKE_BUILD_TYPE sed Commit 6b7998b narrowed matching CMAKE_BUILD_TYPE too successfully and led to a string like `set(CMAKE_BUILD_TYPE)` being left over. Bug: https://bugs.gentoo.org/674768 Closes: https://bugs.gentoo.org/686266 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> eclass/cmake-utils.eclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Is there a reason this fix is only applied to the kde overlay and not the the gentoo.git repo? It is no fix. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3b5582636d219284037ee65bc427194d7e969c4b commit 3b5582636d219284037ee65bc427194d7e969c4b Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2019-05-19 16:15:29 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2019-07-04 19:36:08 +0000 cmake-utils.eclass: _cmake_modify-cmakelists: Fix CMAKE_BUILD_TYPE sed Commit 6b7998b narrowed matching CMAKE_BUILD_TYPE too successfully and led to a string like `set(CMAKE_BUILD_TYPE)` being left over. Bug: https://bugs.gentoo.org/674768 Closes: https://bugs.gentoo.org/686266 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> eclass/cmake-utils.eclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4683e38d6d8e7dcc48307928b85102c1a1867361 commit 4683e38d6d8e7dcc48307928b85102c1a1867361 Author: Rolf Eike Beer <eike@sf-mail.de> AuthorDate: 2019-07-03 20:35:08 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2019-07-04 19:36:07 +0000 dev-util/cmake: use correct pattern to undo cmake eclass modifications Fixes: 6b7998b644e6f4469a7cb4c64776013a74363866 Closes: https://bugs.gentoo.org/686266 Closes: https://github.com/gentoo/gentoo/pull/12385 Signed-off-by: Rolf Eike Beer <eike@sf-mail.de> Closes: https://github.com/gentoo/gentoo/pull/12385 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> dev-util/cmake/cmake-3.14.3.ebuild | 2 +- dev-util/cmake/cmake-3.14.5.ebuild | 2 +- dev-util/cmake/cmake-3.15.0_rc3.ebuild | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) |