Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 686266 - dev-util/cmake-3.14.3: _cmake_modify-cmakelists is breaking tests
Summary: dev-util/cmake-3.14.3: _cmake_modify-cmakelists is breaking tests
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords: PullRequest, TESTFAILURE
Depends on:
Blocks:
 
Reported: 2019-05-18 22:42 UTC by Thomas Deutschmann (RETIRED)
Modified: 2019-07-04 19:39 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,634.70 KB, text/plain)
2019-05-18 22:42 UTC, Thomas Deutschmann (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Deutschmann (RETIRED) gentoo-dev 2019-05-18 22:42:19 UTC
Created attachment 577242 [details]
build.log

> 99% tests passed, 2 tests failed out of 556
> 
> Label Time Summary:
> Label1    =   0.04 sec*proc (1 test)
> Label2    =   0.04 sec*proc (1 test)
> 
> Total Test time (real) = 1056.01 sec
> 
> The following tests FAILED:
>          43 - OutDir (Failed)
>         279 - CMakeOnly.SelectLibraryConfigurations (Failed)
> Errors while running CTest
>  * ERROR: dev-util/cmake-3.14.3::gentoo failed (test phase):
>  *   Tests failed
> 


Portage 2.3.62 (python 3.6.5-final-0, default/linux/x86/17.0, gcc-8.2.0, glibc-2.29-r2, 4.19.27-gentoo-r1 i686)
=================================================================
System uname: Linux-4.19.27-gentoo-r1-i686-Intel-R-_Core-TM-_i7-3770K_CPU_@_3.50GHz-with-gentoo-2.6
KiB Mem:     3106596 total,    436820 free
KiB Swap:     488276 total,    452180 free
Timestamp of repository gentoo: Sat, 18 May 2019 20:44:31 +0000
Head commit of repository gentoo: be3ad16df89024fc853bd8b6415ba51431f87404

sh bash 4.4_p23-r1
ld GNU ld (Gentoo 2.31.1 p7) 2.31.1
ccache version 3.6 [disabled]
app-shells/bash:          4.4_p23-r1::gentoo
dev-java/java-config:     2.2.0-r4::gentoo
dev-lang/perl:            5.26.2::gentoo
dev-lang/python:          2.7.15::gentoo, 3.6.5::gentoo
dev-util/ccache:          3.6::gentoo
dev-util/cmake:           3.9.6::gentoo
sys-apps/baselayout:      2.6-r1::gentoo
sys-apps/openrc:          0.41.2::gentoo
sys-apps/sandbox:         2.13::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.69-r4::gentoo
sys-devel/automake:       1.16.1-r1::gentoo
sys-devel/binutils:       2.31.1-r6::gentoo
sys-devel/gcc:            8.2.0-r6::gentoo, 8.3.0-r1::gentoo
sys-devel/gcc-config:     2.0::gentoo
sys-devel/libtool:        2.4.6-r3::gentoo
sys-devel/make:           4.2.1-r4::gentoo
sys-kernel/linux-headers: 4.14-r1::gentoo (virtual/os-headers)
sys-libs/glibc:           2.29-r2::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/gentoo.git
    priority: -1000

ABI="x86"
ABI_X86="32"
ACCEPT_KEYWORDS="x86"
ACCEPT_LICENSE="* -@EULA"
ACCEPT_PROPERTIES="*"
ACCEPT_RESTRICT="*"
ARCH="x86"
BROOT=""
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=pentium4m -mtune=pentium4m -Wno-error=jump-misses-init -Wno-error=sign-compare"
CHOST="i686-pc-linux-gnu"
CHOST_x86="i686-pc-linux-gnu"
COLLISION_IGNORE="/lib/modules/*"
CONFIG_PROTECT="/etc /etc/stunnel/stunnel.conf /opt/fhem /usr/share/config /usr/share/gnupg/qualified.txt /var/lib/fhem"
CPU_FLAGS_X86="mmx mmxext sse sse2"
CXXFLAGS="-O2 -pipe -march=pentium4m -mtune=pentium4m -Wno-error=jump-misses-init -Wno-error=sign-compare"
DEFAULT_ABI="x86"
EDITOR="/usr/bin/mcedit"
ELIBC="glibc"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
EPREFIX=""
EROOT="/"
ESYSROOT="/"
FCFLAGS="-O2 -march=i686 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs cgroup config-protect-if-modified distlocks downgrade-backup ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -march=i686 -pipe"
GCC_SPECS=""
GRUB_PLATFORMS="efi-32 pc"
GSETTINGS_BACKEND="dconf"
HOME="/root"
INFOPATH="/usr/share/gcc-data/i686-pc-linux-gnu/8.2.0/info:/usr/share/binutils-data/i686-pc-linux-gnu/2.31.1/info:/usr/share/info"
INPUT_DEVICES="libinput keyboard mouse"
IUSE_IMPLICIT="abi_x86_32 prefix prefix-guest prefix-stack"
JAVAC="/etc/java-config-2/current-system-vm/bin/javac"
JAVA_HOME="/etc/java-config-2/current-system-vm"
JDK_HOME="/etc/java-config-2/current-system-vm"
KERNEL="linux"
L10N="en en-US de de-DE"
LANG="en_US.UTF-8"
LC_ALL="en_US.UTF-8"
LC_MESSAGES="C"
LC_PAPER="de_DE.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LIBDIR_x86="lib"
LINGUAS="en de"
LOGNAME="root"
MAIL="/var/mail/root"
MAKEOPTS="--jobs 5 --load-average 7.95"
MULTILIB_ABIS="x86"
NETBEANS_MODULES="apisupport cnd groovy gsf harness ide identity j2ee java mobility nb php profiler soa visualweb webcommon websvccommon xml"
NOCOLOR="true"
OFFICE_IMPLEMENTATION="libreoffice"
OLDPWD="/usr/portage/sys-devel/llvm"
OPENCL_PROFILE="ocl-icd"
OPENGL_PROFILE="xorg-x11"
PAGER="/usr/bin/less"
PATH="/usr/lib/llvm/7/bin:/usr/lib/llvm/6/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/bin"
PHP_TARGETS="php5-6 php7-1 php7-2 php7-3"
POSTGRES_TARGETS="postgres9_5 postgres10"
PWD="/tmp/stable"
PYTHONDONTWRITEBYTECODE="1"
PYTHON_SINGLE_TARGET="python3_6"
PYTHON_TARGETS="python2_7 python3_6"
QT_GRAPHICSSYSTEM="raster"
ROOT="/"
ROOTPATH="/usr/lib/llvm/7/bin:/usr/lib/llvm/6/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/bin"
RUBY_TARGETS="ruby24"
SBCL_HOME="/usr/lib/sbcl"
SBCL_SOURCE_ROOT="/usr/lib/sbcl/src"
SHELL="/bin/bash"
SHLVL="2"
SSH_TTY="/dev/pts/0"
SYSROOT="/"
TERM="tmux-256color"
TMUX="/tmp//tmux-0/default,4271,0"
TMUX_PANE="%2"
TWISTED_DISABLE_WRITING_OF_PLUGIN_CACHE="1"
USER="root"
USERLAND="GNU"
VIDEO_CARDS="vmware"
XDG_CONFIG_DIRS="/etc/xdg"
XDG_DATA_DIRS="/usr/local/share:/usr/share"
Comment 1 Andreas Sturmlechner gentoo-dev 2019-05-19 17:42:53 UTC
I can definitely confirm that disabling _cmake_modify-cmakelists is fixing the tests for me.
Comment 2 Larry the Git Cow gentoo-dev 2019-05-19 17:52:27 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=e805777440326a241ed04343a995ed0cecddd682

commit e805777440326a241ed04343a995ed0cecddd682
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2019-05-19 16:15:29 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2019-05-19 16:48:05 +0000

    cmake-utils.eclass: _cmake_modify-cmakelists: Fix CMAKE_BUILD_TYPE sed
    
    Commit 6b7998b narrowed matching CMAKE_BUILD_TYPE too successfully and led
    to a string like `set(CMAKE_BUILD_TYPE)` being left over.
    
    Bug: https://bugs.gentoo.org/674768
    Closes: https://bugs.gentoo.org/686266
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 eclass/cmake-utils.eclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 3 Robert Gusztav 2019-05-31 07:08:07 UTC
Is there a reason this fix is only applied to the kde overlay and not the the gentoo.git repo?
Comment 4 Andreas Sturmlechner gentoo-dev 2019-05-31 13:07:25 UTC
It is no fix.
Comment 5 Larry the Git Cow gentoo-dev 2019-07-04 19:39:52 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3b5582636d219284037ee65bc427194d7e969c4b

commit 3b5582636d219284037ee65bc427194d7e969c4b
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2019-05-19 16:15:29 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2019-07-04 19:36:08 +0000

    cmake-utils.eclass: _cmake_modify-cmakelists: Fix CMAKE_BUILD_TYPE sed
    
    Commit 6b7998b narrowed matching CMAKE_BUILD_TYPE too successfully and led
    to a string like `set(CMAKE_BUILD_TYPE)` being left over.
    
    Bug: https://bugs.gentoo.org/674768
    Closes: https://bugs.gentoo.org/686266
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 eclass/cmake-utils.eclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4683e38d6d8e7dcc48307928b85102c1a1867361

commit 4683e38d6d8e7dcc48307928b85102c1a1867361
Author:     Rolf Eike Beer <eike@sf-mail.de>
AuthorDate: 2019-07-03 20:35:08 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2019-07-04 19:36:07 +0000

    dev-util/cmake: use correct pattern to undo cmake eclass modifications
    
    Fixes: 6b7998b644e6f4469a7cb4c64776013a74363866
    Closes: https://bugs.gentoo.org/686266
    Closes: https://github.com/gentoo/gentoo/pull/12385
    Signed-off-by: Rolf Eike Beer <eike@sf-mail.de>
    Closes: https://github.com/gentoo/gentoo/pull/12385
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 dev-util/cmake/cmake-3.14.3.ebuild     | 2 +-
 dev-util/cmake/cmake-3.14.5.ebuild     | 2 +-
 dev-util/cmake/cmake-3.15.0_rc3.ebuild | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)