Bug 679220 – media-gfx/gimp breaks application desktop name to zzz-gimp.desktop

• Product: Gentoo Linux
• Status: CONFIRMED ---

[Description Mart Raudsepp 2019-03-02 08:13:47 UTC]

Bug 321111 added a workaround for (accidentally) not defaulting to gimp for PDF files. This is not how defaults should be affected, and ever since this was done, all actual defaults set by gnome-session for GNOME sessions have been broken, because it kept referring to gimp.desktop, not zzz-gimp.desktop.
Maybe this was acceptable back in 2011 (sans not figuring to update these defauls), but these days desktop files are a very important identifier for GUI apps, and renaming it for a workaround is bad. Please consider removing this hack and relying on having PDF defaults set up per-desktop via proper *mimeapps.list files in /usr/share/applications

Note that changing it back now would now constitute a full application change for desktops again, and e.g. if someone has added zzz-gimp application to gnome-shell sidebase favorites, it'll disappear, as there's no zzz-gimp then. So maybe keep both for now, and remove the zzz or both once upstream does a (modern days) proper reverse DNS for the desktop file, e.g. org.gimp.Gimp.desktop

I'm going to add zzz-gimp to our defaults list for the time being, but it's not the only place potentially affected. All other things interacting with GUI applications via desktop files are assuming gimp.desktop as well.

[Comment 1 Larry the Git Cow 2019-03-02 09:25:26 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ca48a3124cabb263143c84930d9c43358c83a567

commit ca48a3124cabb263143c84930d9c43358c83a567
Author:     Mart Raudsepp <[e-mail]>
AuthorDate: 2019-03-02 09:23:41 +0000
Commit:     Mart Raudsepp <[e-mail]>
CommitDate: 2019-03-02 09:24:10 +0000

    gnome-base/gnome-session: bump to 3.28.1, update MIME defaults
    
    Meson port. Supports consolekit together with systemd (so it could
    support booting up without systemd still having fallback to CK then),
    but also no session tracking at all. Express this in the ebuild for
    the time being, even though using null backend is probably bad. Will
    revisit once elogind support is added, but meanwhile this allows to
    have the package at least installed on non-systemd systems without
    relying on deprecated CK.
    Many X11 deps are gone with the meson port, and some since long ago
    with autotools, but not updated earlier.
    Also clean up some pure RDEPEND vs COMMON_DEPEND stuff (dbus-glib
    was wrongly in DEPEND only, xdg-user-dirs* was wrongly in COMMON_DEPEND).
    
    Update gnome-mimeapps.list with newer desktop files and fix some
    messup with brasero stuff, and zzz-gimp.desktop.
    
    Bug: https://bugs.gentoo.org/679220
    Package-Manager: Portage-2.3.52, Repoman-2.3.12
    Signed-off-by: Mart Raudsepp <[e-mail]>

 gnome-base/gnome-session/Manifest                  |   1 +
 gnome-base/gnome-session/files/defaults.list-r4    | 335 +++++++++++++++++++++
 .../gnome-session/gnome-session-3.28.1.ebuild      | 114 +++++++
 gnome-base/gnome-session/metadata.xml              |   3 +
 4 files changed, 453 insertions(+)

[Comment 2 Pacho Ramos 2019-06-03 10:32:27 UTC]

Personally I would simply drop old zzz-gimp.desktop in favor of default one. I know it will cause the .desktop to disappear from people that added it to their desktop/docks, but I think it is really easy to get the icons back. We could simply add an ewarn telling people that .desktop file was renamed and I think they will simply readd it if needed