Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 678502

Summary: dev-db/sqlcipher-3.4.2 USE=libressl - sqlite3.c:21642:18: error: static declaration of ‘HMAC_CTX_new’ follows non-static declaration
Product: Gentoo Linux Reporter: Dmitry Grigoriev <dimgel>
Component: Current packagesAssignee: Sergey Popov <pinkbyte>
Status: RESOLVED FIXED    
Severity: normal CC: dimgel, marcel.schilling, toralf
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 561854    
Attachments: build.log
emerge --info
Fixing the patch which made it upstream, breaking this for LibreSSL-2.8.X users
ebuild to use proposed patch

Description Dmitry Grigoriev 2019-02-21 16:06:12 UTC
Created attachment 565988 [details]
build.log

Recently subj was removed from "libressl" overlay.
Attempt to rebuild it from main "gentoo" repo fails.
Comment 1 Dmitry Grigoriev 2019-02-21 16:06:59 UTC
Created attachment 565990 [details]
emerge --info
Comment 2 pagorman 2019-02-22 20:08:50 UTC
Notice that this error is only the case when you use Libressl >= v2.8

Lets fix that.

the normal "patches" array doesnt seem to do the trick. Meanwhile, v3.4.1 has patch which is upstreamed into v3.4.2 - which treats all versions of LibreSLL alike.

uploading an ebuild to address this - the "-r1" ebuild uses the sqlcipher-3.4.2-libressl.patch to discern that my LibreSSL-2.8.X does not need the code block which statically defines (and thus conflicts with) that piece of hmac.h

Any testing with LibreSSL v2.7 would be appreciated - that is, if we're not going to deprecate it soon.
Comment 3 pagorman 2019-02-22 20:13:03 UTC
Created attachment 566112 [details, diff]
Fixing the patch which made it upstream, breaking this for LibreSSL-2.8.X users

LibreSSL v2.7 and v2.8 needed the same patch from sqlcipher-3.4.1 handled differently. Too bad we upstreamed code in support of a should-be-deprecated old version.
Comment 4 pagorman 2019-02-22 20:14:45 UTC
Created attachment 566114 [details]
ebuild to use proposed patch
Comment 5 Marcel Schilling 2019-02-22 21:20:34 UTC
duplicate of https://bugs.gentoo.org/show_bug.cgi?id=655388?
Comment 6 Aaron Bauman (RETIRED) gentoo-dev 2019-02-22 23:39:04 UTC
*** Bug 655388 has been marked as a duplicate of this bug. ***
Comment 7 Larry the Git Cow gentoo-dev 2019-02-26 09:55:48 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1f3fafce7f1c7c2a2c06a2ac8bd43347de4d929f

commit 1f3fafce7f1c7c2a2c06a2ac8bd43347de4d929f
Author:     Sergey Popov <pinkbyte@gentoo.org>
AuthorDate: 2019-02-26 09:54:37 +0000
Commit:     Sergey Popov <pinkbyte@gentoo.org>
CommitDate: 2019-02-26 09:54:37 +0000

    dev-db/sqlcipher: fix building with LibreSSL 2.8
    
    Signed-off-by: Sergey Popov <pinkbyte@gentoo.org>
    Reported-by: Dmitry Grigoriev <dimgel@mail.ru>
    Closes: https://bugs.gentoo.org/678502
    Package-Manager: Portage-2.3.51, Repoman-2.3.10

 dev-db/sqlcipher/files/sqlcipher-3.4.2-libressl-2.8.patch | 11 +++++++++++
 dev-db/sqlcipher/sqlcipher-3.4.2.ebuild                   |  5 ++++-
 2 files changed, 15 insertions(+), 1 deletion(-)