Summary: | www-client/firefox-65.0 - .../work/firefox-65.0/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:693:44: error: 'VP8E_SET_GF_CBR_BOOST_PCT' was not declared in this scope | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Andre Müller <andre.muller> |
Component: | Current packages | Assignee: | Mozilla Gentoo Team <mozilla> |
Status: | RESOLVED DUPLICATE | ||
Severity: | normal | ||
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | firefox-65.0 build log |
Description
Andre Müller
2019-01-29 15:26:40 UTC
Same problem here while compiling with clang-7.0.1. 38:18.90 In file included from /var/tmp/portage/www-client/firefox-65.0/work/firefox-65.0/ff/media/webrtc/trunk/webrtc/modules/video_coding/webrtc_vp8_gn/Unified_cpp_webrtc_vp8_gn0.cpp:38: 38:18.90 /var/tmp/portage/www-client/firefox-65.0/work/firefox-65.0/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:693:44: error: use of undeclared identifier 'VP8E_SET_GF_CBR_BOOST_PCT' 38:18.90 vpx_codec_control(&(encoders_[i]), VP8E_SET_GF_CBR_BOOST_PCT, 38:18.90 ^ 38:18.90 /var/tmp/portage/www-client/firefox-65.0/work/firefox-65.0/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:1192:35: error: use of undeclared identifier 'VPXD_GET_LAST_QUANTIZER' 38:18.90 vpx_codec_control(decoder_, VPXD_GET_LAST_QUANTIZER, &qp); 38:18.91 ^ 38:18.91 2 errors generated. 38:18.91 gmake[5]: *** [/var/tmp/portage/www-client/firefox-65.0/work/firefox-65.0/config/rules.mk:1133: Unified_cpp_webrtc_vp8_gn0.i_o] Error 1 38:18.91 gmake[5]: Leaving directory '/var/tmp/portage/www-client/firefox-65.0/work/firefox-65.0/ff/media/webrtc/trunk/webrtc/modules/video_coding/webrtc_vp8_gn' 38:18.91 gmake[4]: *** [/var/tmp/portage/www-client/firefox-65.0/work/firefox-65.0/config/recurse.mk:74: media/webrtc/trunk/webrtc/modules/video_coding/webrtc_vp8_gn/target] Error 2 I think that media-libs/libvpx >= 1.7.0 is needed in order to compile Firefox-65.0. I'm testing it now and I'll let you know. For now, after checking the libvpx code, it seems that I'm on the right direction. With libvpx-1.5.0, which is the stable version, the VP8E_SET_GF_CBR_BOOST_PCT and VPXD_GET_LAST_QUANTIZER are not defined. # find libvpx-1.5.0/ -type f -exec grep VP8E_SET_GF_CBR_BOOST_PCT {} + # find libvpx-1.5.0/ -type f -exec grep VPXD_GET_LAST_QUANTIZER {} + The both find commands return no results. But on libvpx-1.7.0 are present: # find libvpx-1.7.0/ -type f -exec grep VPXD_GET_LAST_QUANTIZER {} + libvpx-1.7.0/vp8/vp8_dx_iface.c: { VPXD_GET_LAST_QUANTIZER, vp8_get_quantizer }, libvpx-1.7.0/vpx/vp8dx.h: VPXD_GET_LAST_QUANTIZER, libvpx-1.7.0/vpx/vp8dx.h:VPX_CTRL_USE_TYPE(VPXD_GET_LAST_QUANTIZER, int *) libvpx-1.7.0/vpx/vp8dx.h:#define VPX_CTRL_VPXD_GET_LAST_QUANTIZER libvpx-1.7.0/vp9/vp9_dx_iface.c: { VPXD_GET_LAST_QUANTIZER, ctrl_get_quantizer }, libvpx-1.7.0/vpxdec.c: if (vpx_codec_control(&decoder, VPXD_GET_LAST_QUANTIZER, &qp)) { libvpx-1.7.0/vpxdec.c: warn("Failed VPXD_GET_LAST_QUANTIZER: %s", # find libvpx-1.7.0/ -type f -exec grep VP8E_SET_GF_CBR_BOOST_PCT {} + libvpx-1.7.0/examples/vpx_temporal_svc_encoder.c: vpx_codec_control(&codec, VP8E_SET_GF_CBR_BOOST_PCT, 0); libvpx-1.7.0/test/datarate_test.cc: encoder->Control(VP8E_SET_GF_CBR_BOOST_PCT, gf_boost_); libvpx-1.7.0/vp8/vp8_cx_iface.c: extra_cfg.gf_cbr_boost_pct = CAST(VP8E_SET_GF_CBR_BOOST_PCT, args); libvpx-1.7.0/vp8/vp8_cx_iface.c: { VP8E_SET_GF_CBR_BOOST_PCT, ctrl_set_rc_gf_cbr_boost_pct }, libvpx-1.7.0/vpx/vp8cx.h: VP8E_SET_GF_CBR_BOOST_PCT, libvpx-1.7.0/vpx/vp8cx.h:VPX_CTRL_USE_TYPE(VP8E_SET_GF_CBR_BOOST_PCT, unsigned int) libvpx-1.7.0/vpx/vp8cx.h:#define VPX_CTRL_VP8E_SET_GF_CBR_BOOST_PCT libvpx-1.7.0/vpxenc.c: VP8E_SET_GF_CBR_BOOST_PCT, I did not check if VP8E_SET_GF_CBR_BOOST_PCT and VPXD_GET_LAST_QUANTIZER are defined in libvpx-1.6.0. Firefox is still compiling, I'll let you know once it finish. I checked that VP8E_SET_GF_CBR_BOOST_PCT and VPXD_GET_LAST_QUANTIZER are not defined on libvpx-1.6.0. So the Firefox-65.0 ebuild should be patched like that: @@ -88,7 +88,7 @@ system-icu? ( >=dev-libs/icu-60.2:= ) system-jpeg? ( >=media-libs/libjpeg-turbo-1.2.1 ) system-libevent? ( >=dev-libs/libevent-2.0:0= ) - system-libvpx? ( >=media-libs/libvpx-1.5.0:0=[postproc] ) + system-libvpx? ( >=media-libs/libvpx-1.7.0:0=[postproc] ) system-sqlite? ( >=dev-db/sqlite-3.25.3:3[secure-delete,debug=] ) system-webp? ( >=media-libs/libwebp-1.0.1:0= ) wifi? ( kernel_linux? ( >=sys-apps/dbus-0.60 I can confirm firefox 65 builds with libvpx-1.7.0 *** This bug has been marked as a duplicate of bug 676762 *** I can confirm it builds against libvpx-1.7.0 Thanks Armitage, all! |