Summary: | www-client/firefox-63.0 fails to build ff/toolkit/library/x86_64-unknown-linux-gnu/release/build/style-94bc691f5157d254/out/gecko/bindings.rs:640:5 ^ unexpected token | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Patrick McLean <chutzpah> |
Component: | Current packages | Assignee: | Mozilla Gentoo Team <mozilla> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | hydrapolic |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | build.log (xzipped) |
Description
Patrick McLean
2018-10-25 00:49:11 UTC
The exact error: 5:47.81 /var/tmp/portage/www-client/firefox-63.0/work/firefox-63.0/dom/canvas/OffscreenCanvas.cpp:344:3: note: in expansion of macro 'NS_INTERFACE_MAP_ENTRY' 5:47.81 NS_INTERFACE_MAP_ENTRY(nsISupports) 5:47.81 ^~~~~~~~~~~~~~~~~~~~~~ 5:51.33 gmake[4]: Leaving directory '/var/tmp/portage/www-client/firefox-63.0/work/firefox-63.0/ff/dom/canvas' 5:57.45 Compiling style v0.0.1 (file:///var/tmp/portage/www-client/firefox-63.0/work/firefox-63.0/servo/components/style) 6:14.23 error: expected one of `crate`, `fn`, `pub`, `static`, `type`, or `}`, found `;` 6:14.23 --> /var/tmp/portage/www-client/firefox-63.0/work/firefox-63.0/ff/toolkit/library/x86_64-unknown-linux-gnu/release/build/style-94bc691f5157d254/out/gecko/bindings.rs:640:5 6:14.23 | 6:14.23 639 | extern "C" { 6:14.23 | - expected one of `crate`, `fn`, `pub`, `static`, `type`, or `}` here 6:14.23 640 | ; 6:14.23 | ^ unexpected token 6:14.25 error: aborting due to previous error 6:14.26 error: Could not compile `style`. 6:14.26 warning: build failed, waiting for other jobs to finish... 7:06.40 error: build failed 7:06.41 gmake[4]: *** [/var/tmp/portage/www-client/firefox-63.0/work/firefox-63.0/config/rules.mk:1030: force-cargo-library-build] Error 101 7:06.41 gmake[4]: Leaving directory '/var/tmp/portage/www-client/firefox-63.0/work/firefox-63.0/ff/toolkit/library/rust' 7:06.41 gmake[3]: *** [/var/tmp/portage/www-client/firefox-63.0/work/firefox-63.0/config/recurse.mk:74: toolkit/library/rust/target] Error 2 7:06.41 gmake[3]: Leaving directory '/var/tmp/portage/www-client/firefox-63.0/work/firefox-63.0/ff' 7:06.41 gmake[2]: *** [/var/tmp/portage/www-client/firefox-63.0/work/firefox-63.0/config/recurse.mk:34: compile] Error 2 7:06.41 gmake[2]: Leaving directory '/var/tmp/portage/www-client/firefox-63.0/work/firefox-63.0/ff' 7:06.41 gmake[1]: *** [/var/tmp/portage/www-client/firefox-63.0/work/firefox-63.0/config/rules.mk:432: default] Error 2 7:06.41 gmake[1]: Leaving directory '/var/tmp/portage/www-client/firefox-63.0/work/firefox-63.0/ff' 7:06.41 gmake: *** [client.mk:150: build] Error 2 7:06.45 0 compiler warnings present. I cannot reproduce and haven't seen this before. All I found was https://bugzilla.mozilla.org/show_bug.cgi?id=1432514 and the solution was to upgrade 'rustfmt'. I don't have "rustfmt" on my system: -bash: rustfmt: command not found Do you have "rustfmt" somehow on your system? I am currently trying to build firefox again with dev-util/rustfmt-0.8.6 installed to see if this will cause any failures. I can reproduce when dev-util/rustfmt-0.8.6 is installed. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9a1471422a7efdeb89d7d561d54914197a543627 commit 9a1471422a7efdeb89d7d561d54914197a543627 Author: Thomas Deutschmann <whissi@gentoo.org> AuthorDate: 2018-10-25 12:37:52 +0000 Commit: Thomas Deutschmann <whissi@gentoo.org> CommitDate: 2018-10-25 12:38:12 +0000 dev-util/rustfmt: bump to v0.9.0 Bug: https://bugs.gentoo.org/669548 Package-Manager: Portage-2.3.51, Repoman-2.3.11 Signed-off-by: Thomas Deutschmann <whissi@gentoo.org> dev-util/rustfmt/Manifest | 1 + dev-util/rustfmt/rustfmt-0.9.0.ebuild | 62 +++++++++++++++++++++++++++++++++++ 2 files changed, 63 insertions(+) It looks like it works somehow with rustfmt-0.9.0 (which I don't understand because I think we need https://github.com/rust-lang-nursery/rustfmt/commit/97d29ff2e17ab1b259d9acc9010c72d2b6870f73 which is only present in rustfmt nightly I cannot create an ebuild for due to "nightly" in the name cargo eclass doesn't support). So please update... At this step I don't really want to add rustfmt as dependency. I am trying to disable external rustfmt usage because it isn't required... The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e530a268c3003ad7455cad8fe0b5b8bf23f8f21a commit e530a268c3003ad7455cad8fe0b5b8bf23f8f21a Author: Thomas Deutschmann <whissi@gentoo.org> AuthorDate: 2018-10-25 17:27:25 +0000 Commit: Thomas Deutschmann <whissi@gentoo.org> CommitDate: 2018-10-25 17:28:00 +0000 www-client/firefox: don't use rustfmt In addition, move eapply_user to the beginning of src_prepare to increase the chance to apply upstream patches without the need for changes. Closes: https://bugs.gentoo.org/669548 Package-Manager: Portage-2.3.51, Repoman-2.3.11 Signed-off-by: Thomas Deutschmann <whissi@gentoo.org> www-client/firefox/firefox-63.0.ebuild | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) |