Summary: | www-client/chromium-70.0.3538.67 with media-libs/harfbuzz-2.0.0 - error: no matching function for call to 'hb_font_funcs_set_glyph_h_advances_func' | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Patrick Lauer <patrick> |
Component: | Current packages | Assignee: | Chromium Project <chromium> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | 1i5t5.duncan, alexandref75, audvare, finkandreas, gentoo-bugs, gentoo, gnome, huglovefan, marduk, mark+gentoobugs, mgorny, neil, office, polynomial-c, vanilla.sources |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
Patch to enable chromium with harfbuzz 2.0
ebuild patch to enable harfbuzz 2.0 on chromium Fix harfbuzz 2.0 build failure |
Description
Patrick Lauer
2018-10-19 18:49:08 UTC
Probably this harfbuzz commit broke it. https://github.com/harfbuzz/harfbuzz/commit/bee93e269711a3eda4e7d762b730522564fe6e87 (In reply to Mike Gilbert from comment #1) > Probably this harfbuzz commit broke it. > > https://github.com/harfbuzz/harfbuzz/commit/bee93e269711a3eda4e7d762b730522564fe6e87 Get vs. set? The given commit modifies the get functions, while the missing match is a set function. (In reply to Duncan from comment #2) > > Get vs. set? The given commit modifies the get functions, while the missing > match is a set function. Ahh... Get inside the set. (I'll shutup now.) Created attachment 552026 [details, diff]
Patch to enable chromium with harfbuzz 2.0
Created attachment 552028 [details, diff]
ebuild patch to enable harfbuzz 2.0 on chromium
(In reply to Alexandre Ferreira from comment #4) > Created attachment 552026 [details, diff] [details, diff] > Patch to enable chromium with harfbuzz 2.0 Build succeeds with this patch and resulting binary is functional. This should be fixed in harfbuzz-2.0.1, latest harfbuzz is 2.0.2 too. (In reply to Joonas Niilola from comment #7) > This should be fixed in harfbuzz-2.0.1, latest harfbuzz is 2.0.2 too. 2.0.2 fails the same. commit 71d9fb289115bab6ca06290756bd40725bd82e34 Author: Lars Wendler <polynomial-c@gentoo.org> AuthorDate: Sun Oct 21 13:18:07 2018 Commit: Lars Wendler <polynomial-c@gentoo.org> CommitDate: Sun Oct 21 13:18:07 2018 media-libs/harfbuzz: Bump to version 2.0.2 Signed-off-by: Lars Wendler <polynomial-c@gentoo.org> Package-Manager: Portage-2.3.51, Repoman-2.3.11 Comment on attachment 552026 [details, diff]
Patch to enable chromium with harfbuzz 2.0
Thanks for the patch.
Unfortunately, it introduces several pointless formatting changes and is not suitable for submission upstream.
1. Converts spaces to tabs before "void* font_data".
2. Changes "unsigned" to "unsigned int". These are equivalent expressions in C++.
3. Moves the asterisk in pointer declarations from left to right.
Created attachment 552096 [details, diff]
Fix harfbuzz 2.0 build failure
Here's a cleaned-up patch. I am testing it now.
Hmm... so this patch fixes the issue with >=harfbuzz-2, but it breaks with <harfbuzz-2. I want to avoid conditional patching, so I will probably revbump the stable ebuild and apply the patch there. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=71fefc9233564d56103ad143ff8e768d18bcf89b commit 71fefc9233564d56103ad143ff8e768d18bcf89b Author: Mike Gilbert <floppym@gentoo.org> AuthorDate: 2018-10-21 15:16:26 +0000 Commit: Mike Gilbert <floppym@gentoo.org> CommitDate: 2018-10-21 15:17:02 +0000 www-client/chromium: fix build with harfbuzz-2 Bug: https://bugs.gentoo.org/669034 Package-Manager: Portage-2.3.51_p1, Repoman-2.3.11_p26 Signed-off-by: Mike Gilbert <floppym@gentoo.org> .../chromium/chromium-70.0.3538.67-r1.ebuild | 701 +++++++++++++++++++++ www-client/chromium/chromium-70.0.3538.67.ebuild | 3 +- .../chromium/files/chromium-harfbuzz-r0.patch | 80 +++ 3 files changed, 783 insertions(+), 1 deletion(-) The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3ebb567656052386de62e5edefad9487ce5f3b32 commit 3ebb567656052386de62e5edefad9487ce5f3b32 Author: Mike Gilbert <floppym@gentoo.org> AuthorDate: 2018-10-22 00:19:41 +0000 Commit: Mike Gilbert <floppym@gentoo.org> CommitDate: 2018-10-22 00:19:41 +0000 www-client/chromium: dev channel bump (71.0.3578.10) Closes: https://bugs.gentoo.org/669034 Package-Manager: Portage-2.3.51_p1, Repoman-2.3.11_p26 Signed-off-by: Mike Gilbert <floppym@gentoo.org> www-client/chromium/Manifest | 2 +- ...{chromium-71.0.3559.6.ebuild => chromium-71.0.3578.10.ebuild} | 9 ++++++--- 2 files changed, 7 insertions(+), 4 deletions(-) |