| Summary: | =dev-qt/qtwebkit-5.212.0_pre20180120 breaks with USE="-hyphen" | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | David Flogeras <dflogeras2> |
| Component: | Current packages | Assignee: | Qt Bug Alias <qt> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | jstein, throw_away_2002 |
| Priority: | Normal | Keywords: | PATCH |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | qtwebkit-honor-hyphen-useflag.patch | ||
|
Description
David Flogeras
2018-09-22 11:10:29 UTC
I also see this. Most people will not, unless they no not have hyphen installed, and happen to notice a new USE flag defaulting to on, and decide to turn it off. qtwebkit _will_ merge with USE="-hyphen" _if_ the hyphen package is already installed. So maybe: a) the ebuild needs to communicate to the underlying build system not to look for hyphen or attempt to use it. b) hyphen is not an optional dep, and the USE token should be removed and the hyphen package made a hard dep. > a) the ebuild needs to communicate to the underlying build system not to
> look for hyphen or attempt to use it.
> b) hyphen is not an optional dep, and the USE token should be removed and
> the hyphen package made a hard dep.
Looks like it's the (a) option. I've attached the patch to pass the corresponding flag to cmake.
Created attachment 548236 [details, diff]
qtwebkit-honor-hyphen-useflag.patch
(In reply to Alexander Sergeyev from comment #3) > Created attachment 548236 [details, diff] [details, diff] > qtwebkit-honor-hyphen-useflag.patch The above patch worked perfectly for my systems, thanks Alexander! (In reply to Alexander Sergeyev from comment #3) > Created attachment 548236 [details, diff] [details, diff] > qtwebkit-honor-hyphen-useflag.patch Thanks from me, too. Don't want to install dev-libs/hyphen (or any of the additional dependencies that hyphen drags in). The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1d579b1e892f271ef03140255d03d59b8369e877 commit 1d579b1e892f271ef03140255d03d59b8369e877 Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2018-10-19 19:54:04 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2018-10-19 20:23:29 +0000 dev-qt/qtwebkit: Fix build with !hyphen Closes: https://bugs.gentoo.org/666752 Reported-by: David Flogeras <dflogeras2@gmail.com> Thanks-to: Alexander Sergeyev <sergeev917@gmail.com> Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> Package-Manager: Portage-2.3.51, Repoman-2.3.11 dev-qt/qtwebkit/qtwebkit-5.212.0_pre20180120.ebuild | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) |
