| Summary: | media-gfx/exiv2-0.26_p20180319 does not compile with clang (Patch) | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | David Carlos Manuelda <StormByte> |
| Component: | Current packages | Assignee: | Gentoo Graphics Project <graphics+disabled> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | jstein, kde |
| Priority: | Normal | Keywords: | PATCH |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://dev.exiv2.org/issues/1362 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | Fix Clang compilation | ||
Thanks for your report. Next time, please attach the full original upstream commit including header. (In reply to Andreas Sturmlechner from comment #1) > Thanks for your report. Next time, please attach the full original upstream > commit including header. Well, this patch is the one I made for fixing gentoo's snapshot, I don't know when this has been fixed in upstream, just realize it was fixed, thanks for the hint. Sorry, I wrongly assumed you had taken it from upstream. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=62dd0d84ce139e725fb8890b85fc1cfbff2e0c4e commit 62dd0d84ce139e725fb8890b85fc1cfbff2e0c4e Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2018-08-07 00:08:53 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2018-08-07 07:05:39 +0000 media-gfx/exiv2: Fix build with clang Reported-by: David Carlos Manuelda <StormByte@gmail.com> Closes: https://bugs.gentoo.org/662934 Package-Manager: Portage-2.3.44, Repoman-2.3.10 media-gfx/exiv2/exiv2-0.26_p20180319.ebuild | 3 +- .../files/exiv2-0.26_p20180319-clang-fix.patch | 47 ++++++++++++++++++++++ 2 files changed, 49 insertions(+), 1 deletion(-) |
Created attachment 542534 [details, diff] Fix Clang compilation This version was using -std=gnu++98 for both CXX and CFLAGS, but CLang does not admit it in C mode as it is a c++ flag only, thus it fails compilation. This was reported upstream and checked it is fixed on their github. I attach a patch that solves this issue or recommend another more recent bump.