Summary: | dev-perl/Perl-Critic-Dynamic-0.50.0-r2: test failures: Failed 1/2 test programs | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Thomas Deutschmann (RETIRED) <whissi> |
Component: | Current packages | Assignee: | Gentoo Perl team <perl> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kentnl |
Priority: | Normal | Keywords: | TESTFAILURE |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://rt.cpan.org/Public/Bug/Display.html?id=103382 | ||
See Also: | https://bugs.gentoo.org/show_bug.cgi?id=662294 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 661778 | ||
Attachments: | build.log |
Description
Thomas Deutschmann (RETIRED)
2018-07-22 14:08:34 UTC
Noticing the CGI.pm message, I installed dev-perl/CGI-4.360.0. After that's installed dev-perl/Perl-Critic-Dynamic-0.50.0-r2 passes its tests on alpha. Are we just missing a dep? (In reply to Matt Turner from comment #1) > Noticing the CGI.pm message, I installed dev-perl/CGI-4.360.0. After that's > installed dev-perl/Perl-Critic-Dynamic-0.50.0-r2 passes its tests on alpha. > > Are we just missing a dep? Looks more complicated than that, upstream bugs suggest certain versions of CGI create this issue, and others don't. But will add a dep on CGI just-incase. Hmm, we have patches in -r2 that should have killed off the use of CGI.pm entirely... *flips table* But I guess our patch wasn't extensive enough: $ ebuild Perl-Critic-Dynamic-0.50.0-r2.ebuild clean prepare Appending /usr/local/gentoo to PORTDIR_OVERLAY... * Perl-Critic-Dynamic-0.05.tar.gz BLAKE2B SHA512 size ;-) ... [ ok ] >>> Unpacking source... >>> Unpacking Perl-Critic-Dynamic-0.05.tar.gz to /var/tmp/portage/dev-perl/Perl-Critic-Dynamic-0.50.0-r2/work >>> Source unpacked in /var/tmp/portage/dev-perl/Perl-Critic-Dynamic-0.50.0-r2/work >>> Preparing source in /var/tmp/portage/dev-perl/Perl-Critic-Dynamic-0.50.0-r2/work/Perl-Critic-Dynamic-0.05 ... * Applying Perl-Critic-Dynamic-0.05-test-cgi.patch ... [ ok ] >>> Source prepared. $ sudo grep CGI -r /var/tmp/portage/dev-perl/Perl-Critic-Dynamic-0.50.0-r2/work/Perl-Critic-Dynamic-0.05 /var/tmp/portage/dev-perl/Perl-Critic-Dynamic-0.50.0-r2/work/Perl-Critic-Dynamic-0.05/t/Dynamic/ValidateAgainstSymbolTable.run:use CGI; #also uses Carp /var/tmp/portage/dev-perl/Perl-Critic-Dynamic-0.50.0-r2/work/Perl-Critic-Dynamic-0.05/t/Dynamic/ValidateAgainstSymbolTable.run:use CGI; #also uses Carp *sigh* The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5ef6864dc88e9e5288fd5563155c0e2ee1ef8fb4 commit 5ef6864dc88e9e5288fd5563155c0e2ee1ef8fb4 Author: Kent Fredric <kentnl@gentoo.org> AuthorDate: 2019-07-17 06:40:57 +0000 Commit: Kent Fredric <kentnl@gentoo.org> CommitDate: 2019-07-17 06:41:59 +0000 dev-perl/Perl-Critic-Dynamic: Add dev-perl/CGI into test deps bug #661808 Bug: https://bugs.gentoo.org/661808 Bug: https://bugs.gentoo.org/662294 Package-Manager: Portage-2.3.66, Repoman-2.3.16 Signed-off-by: Kent Fredric <kentnl@gentoo.org> .../Perl-Critic-Dynamic-0.50.0-r3.ebuild | 26 ++++++++++++++++++++++ 1 file changed, 26 insertions(+) The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6797621a48aba27249d1a063714e1a0208404469 commit 6797621a48aba27249d1a063714e1a0208404469 Author: Andreas K. Hüttel <dilfridge@gentoo.org> AuthorDate: 2019-10-16 11:51:38 +0000 Commit: Andreas K. Hüttel <dilfridge@gentoo.org> CommitDate: 2019-10-16 12:35:03 +0000 dev-perl/Perl-Critic-Dynamic: Port stable keywords (only dep additions) Bug: https://bugs.gentoo.org/661808 Package-Manager: Portage-2.3.76, Repoman-2.3.17 Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org> dev-perl/Perl-Critic-Dynamic/Perl-Critic-Dynamic-0.50.0-r3.ebuild | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=26ac335cf12f17352e7b34506e28382cca6c5ddc commit 26ac335cf12f17352e7b34506e28382cca6c5ddc Author: Andreas K. Hüttel <dilfridge@gentoo.org> AuthorDate: 2019-10-25 08:13:19 +0000 Commit: Andreas K. Hüttel <dilfridge@gentoo.org> CommitDate: 2019-10-25 08:13:39 +0000 dev-perl/Perl-Critic-Dynamic: Remove old Closes: https://bugs.gentoo.org/662294 Closes: https://bugs.gentoo.org/661808 Package-Manager: Portage-2.3.77, Repoman-2.3.17 Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org> .../Perl-Critic-Dynamic-0.50.0-r1.ebuild | 20 -------------------- 1 file changed, 20 deletions(-) |