Bug 657580 – [Future EAPI] PMS: inconsistent respecting of insopts/exeopts

• Product: Gentoo Hosted Projects
• Status: RESOLVED FIXED

[Description Michał Górny 2018-06-08 07:09:21 UTC]

At a first glance, the following functions respect:

a. insopts: doconfd, doenvd, doheader, doins.

b. exeopts: doexe, doinitd.

At the same time, we have a lot of functions that ignore those and set 0644/0755 unconditionally (dobin, dodoc, dolib*, etc.).

I suppose respecting it in doheader is a divergence resulting from it being added later.  The others were probably either made to respect it intentionally, or because of Portage implementation.

Do we really have a use case for this?  I'm thinking it would really be cleaner to only have doins/newins respect insopts, and doexe/newexe -- exeopts.

[Comment 1 Ulrich Müller 2018-06-08 07:20:47 UTC]

I think the question is if we care enough to fix it (and thereby introduce EAPI dependent behaviour)?

[Comment 2 Michał Górny 2018-06-08 07:22:39 UTC]

We already did something similar for domo last EAPI.  Sad I didn't spot it back then.

[Comment 3 Larry the Git Cow 2021-05-24 04:55:34 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=cbe923acdb6fae689cdaedc7f00901cd00e2557a

commit cbe923acdb6fae689cdaedc7f00901cd00e2557a
Author:     Michał Górny <[e-mail]>
AuthorDate: 2021-05-12 17:38:16 +0000
Commit:     Zac Medico <[e-mail]>
CommitDate: 2021-05-24 04:52:34 +0000

    Make doconf, doenvd, doheader & doinitd ignore ins/exeopts in EAPI 8
    
    Bug: https://bugs.gentoo.org/657580
    Signed-off-by: Michał Górny <[e-mail]>
    Signed-off-by: Zac Medico <[e-mail]>

 bin/eapi.sh                 | 16 ++++++++++++++++
 bin/ebuild-helpers/doconfd  |  8 +++++++-
 bin/ebuild-helpers/doenvd   |  8 +++++++-
 bin/ebuild-helpers/doheader |  8 +++++++-
 bin/ebuild-helpers/doinitd  |  9 ++++++++-
 5 files changed, 45 insertions(+), 4 deletions(-)

[Comment 4 Larry the Git Cow 2021-06-13 19:18:57 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/pms.git/commit/?id=5567f230848b143218f44ba03393bf810e0b4e54

commit 5567f230848b143218f44ba03393bf810e0b4e54
Author:     Ulrich Müller <[e-mail]>
AuthorDate: 2021-05-16 16:15:04 +0000
Commit:     Ulrich Müller <[e-mail]>
CommitDate: 2021-06-05 08:55:40 +0000

    EAPI 8: insopts and exeopts affect only doins and doexe
    
    Bug: https://bugs.gentoo.org/657580
    Signed-off-by: Ulrich Müller <[e-mail]>

 eapi-differences.tex |  8 +++++++
 pkg-mgr-commands.tex | 64 ++++++++++++++++++++++++++++++++++++++++++----------
 2 files changed, 60 insertions(+), 12 deletions(-)