Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 655356

Summary: app-emulation/spice-0.14.0-r1 : ssl_verify.c:37:29: error: static declaration of ASN1_STRING_get0_data follows non-static declaration
Product: Gentoo Linux Reporter: Toralf Förster <toralf>
Component: Current packagesAssignee: Virtualization Team <virtualization>
Status: RESOLVED FIXED    
Severity: normal CC: biergaizi2009, kfm
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 561854    
Attachments: emerge-info.txt
app-emulation:spice-0.14.0-r1:20180509-011607.log
emerge-history.txt
environment
etc.portage.tbz2
logs.tbz2
temp.tbz2
spice-0.14.0-openssl1.1_fix.patch (revised)

Description Toralf Förster gentoo-dev 2018-05-09 15:54:34 UTC
/bin/sh ../libtool  --tag=CC   --mode=compile x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I..  -I.. -I.. -I/usr/include/pixman-1   -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/opus  -DG_LOG_DOMAIN=\"Spice\" -I/usr/include/spice-1    -O2 -pipe -march=native -c -o ssl_verify.lo ssl_verify.c
libtool: compile:  x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I.. -I/usr/include/pixman-1 -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/opus -DG_LOG_DOMAIN=\"Spice\" -I/usr/include/spice-1 -O2 -pipe -march=native -c ssl_verify.c  -fPIC -DPIC -o .libs/ssl_verify.o
ssl_verify.c:37:29: error: static declaration of ‘ASN1_STRING_get0_data’ follows non-static declaration
 static const unsigned char *ASN1_STRING_get0_data(const ASN1_STRING *asn1)
                             ^~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/openssl/rsa.h:64:0,

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.0-no-multilib-hardened_libressl_20180506-210133

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-7.3.0 *

Available Python interpreters, in order of preference:
  [1]   python3.5
  [2]   python2.7 (fallback)
Available Ruby profiles:
  [1]   ruby23 (with Rubygems) *



emerge -qpv app-emulation/spice
[ebuild  N    ] app-emulation/spice-0.14.0-r1  USE="libressl -gstreamer -lz4 -sasl -smartcard -static-libs"
Comment 1 Toralf Förster gentoo-dev 2018-05-09 15:54:37 UTC
Created attachment 530602 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2018-05-09 15:54:40 UTC
Created attachment 530604 [details]
app-emulation:spice-0.14.0-r1:20180509-011607.log
Comment 3 Toralf Förster gentoo-dev 2018-05-09 15:54:43 UTC
Created attachment 530606 [details]
emerge-history.txt
Comment 4 Toralf Förster gentoo-dev 2018-05-09 15:54:46 UTC
Created attachment 530608 [details]
environment
Comment 5 Toralf Förster gentoo-dev 2018-05-09 15:54:49 UTC
Created attachment 530610 [details]
etc.portage.tbz2
Comment 6 Toralf Förster gentoo-dev 2018-05-09 15:54:52 UTC
Created attachment 530612 [details]
logs.tbz2
Comment 7 Toralf Förster gentoo-dev 2018-05-09 15:54:55 UTC
Created attachment 530614 [details]
temp.tbz2
Comment 8 Pacho Ramos gentoo-dev 2018-06-22 08:36:56 UTC
*** Bug 658214 has been marked as a duplicate of this bug. ***
Comment 9 Pacho Ramos gentoo-dev 2018-06-22 08:37:14 UTC
patch in duplicated bug
https://bugs.gentoo.org/attachment.cgi?id=536050
Comment 10 kfm 2018-07-30 00:46:21 UTC
Here is the official patch, which I cherry-picked from upstream:

https://raw.githubusercontent.com/kerframil/portage-overlay/master/app-emulation/spice/files/spice-0.14.0-openssl1.1_fix.patch
Comment 11 kfm 2018-07-30 00:47:58 UTC
Created attachment 541718 [details, diff]
spice-0.14.0-openssl1.1_fix.patch (revised)
Comment 12 Virgil Dupras (RETIRED) gentoo-dev 2018-08-06 12:26:22 UTC
Kerin: That patch is already being applied on spice 0.14.0-r1, it can't be a fix for this error. We also see in the build log that it was applied in this particular test run.
Comment 13 Virgil Dupras (RETIRED) gentoo-dev 2018-08-06 13:24:51 UTC
I reproduced the build failure in a libressl environment with libressl 2.7 unmasked and confirm that the patch added by Pachos fixes the build failure.

Applying and pushing...
Comment 14 Larry the Git Cow gentoo-dev 2018-08-06 13:27:49 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=85456edb865e51a3c194dae3ff9568249113dd6c

commit 85456edb865e51a3c194dae3ff9568249113dd6c
Author:     Virgil Dupras <vdupras@gentoo.org>
AuthorDate: 2018-08-06 13:27:27 +0000
Commit:     Virgil Dupras <vdupras@gentoo.org>
CommitDate: 2018-08-06 13:27:27 +0000

    app-emulation/spice: fix build for libressl 2.7+
    
    Closes: https://bugs.gentoo.org/655356
    Package-Manager: Portage-2.3.44, Repoman-2.3.10

 app-emulation/spice/files/spice-0.14.0-libressl_fix.patch | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 15 kfm 2018-08-06 15:48:33 UTC
(In reply to Virgil Dupras from comment #12)
> Kerin: That patch is already being applied on spice 0.14.0-r1, it can't be a
> fix for this error. We also see in the build log that it was applied in this
> particular test run.

I distinctly remember it not being there (in its present form) at the time that I tested but you're right of course; it's officially been there since February. I just re-synced from github.com/gentoo-mirror/gentoo and there it is. How that situation came to be is a mystery to me. I even went so far as to push the attached patch into my overlay. Not that any of this matters now. Thanks for resolving.