| Summary: | app-portage/elogviewer-2.7 - remove python2_7 support | ||
|---|---|---|---|
| Product: | Portage Development | Reporter: | Samuel Bauer <samuel.bauer> |
| Component: | Tools | Assignee: | Portage Tools Team <tools-portage> |
| Status: | RESOLVED OBSOLETE | ||
| Severity: | normal | CC: | bkohler, dolsen, Mathias.Laurin+gentoo, tools-portage |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://bugs.gentoo.org/show_bug.cgi?id=721522 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
elogviewer-2.7.ebuild
elogviewer-2.7-r1.patch |
||
It also works with all python3_{4,5}, but package was missing [${PYTHON_USEDEP}] for portage.
> When I use python2_7 elogviewer doesn't work
See #589910
Comment on attachment 524618 [details]
elogviewer-2.7.ebuild
Looks like it was recently changed.
--- elogviewer-2.7-r1.ebuild 2018-03-21 21:44:15.252623687 +0100
+++ - 2018-03-23 07:49:02.618879606 +0100
@@ -1,9 +1,9 @@
-# Copyright 1999-2018 Gentoo Foundation
+# Copyright 1999-2017 Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2
EAPI=6
-PYTHON_COMPAT=( python{2_7,3_4,3_5} )
+PYTHON_COMPAT=( python{3_4,3_5,3_6} )
DISABLE_AUTOFORMATTING=true
@@ -22,13 +22,9 @@
RDEPEND="${PYTHON_DEPS}
|| (
dev-python/PyQt5[gui,widgets,${PYTHON_USEDEP}]
- dev-python/PyQt4[${PYTHON_USEDEP},X]
dev-python/pyside[${PYTHON_USEDEP},X]
)
- || (
- >=sys-apps/portage-2.1[${PYTHON_USEDEP}]
- sys-apps/portage-mgorny[${PYTHON_USEDEP}]
- )
+ >=sys-apps/portage-2.1[${PYTHON_USEDEP}]
$(python_gen_cond_dep 'dev-python/enum34[${PYTHON_USEDEP}]' python2_7)
!dev-python/PyQt5[-gui]
!dev-python/PyQt5[-widgets]
Created attachment 525142 [details, diff]
elogviewer-2.7-r1.patch
My points were
mainly adding python3_6 as a single target (PyQt is really slow to compile when there's a bunch of python targets)
drop PyQt4 support as it would help for qt4 removal process.
Removing python2_7 was just a side effect to ensure not being hurt by #589910 but is not the primary goal of this bug, else I'd rather added a comment there.
However, launching elogviewer-2.7-r1 (the new version) with python2_7 as single target still fails with PyQt5. I'm not sure about PyQt4.
Attached patch is valid for current in tree elogviewer.
Runs fine when using python3_6 as single target.
Doesn't break because of PyQt5/python2_7, conditional about this case are quite
Removes conditional about portage being >=2.1, as all in tree version of portage are.
The current in tree version is a good step as it adds [${PYTHON_USEDEP}] for multiple portage versions.
3.0 now in tree with updated targets, we can close this bug once that is stabilized, I suppose py2 was dropped in commit cd406688, anyway. |
Created attachment 524618 [details] elogviewer-2.7.ebuild When I use python2_7 elogviewer doesn't work It works perfectly fine with python3_6 So I dropped python_target2_7 and added python3_6. As qt4 is in a removal process, I also dropped PyQt4 from the ebuild.