Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 651032 - app-portage/elogviewer-2.7 - remove python2_7 support
Summary: app-portage/elogviewer-2.7 - remove python2_7 support
Status: UNCONFIRMED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Tools (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage Tools Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-20 21:15 UTC by Samuel Bauer
Modified: 2019-09-13 15:24 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
elogviewer-2.7.ebuild (elogviewer-2.7.ebuild,1.77 KB, text/plain)
2018-03-20 21:15 UTC, Samuel Bauer
Details
elogviewer-2.7-r1.patch (elogviewer-2.7-r1.patch,579 bytes, patch)
2018-03-23 22:04 UTC, Samuel Bauer
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Samuel Bauer 2018-03-20 21:15:19 UTC
Created attachment 524618 [details]
elogviewer-2.7.ebuild

When I use python2_7 elogviewer doesn't work

It works perfectly fine with python3_6

So I dropped python_target2_7 and added python3_6.

As qt4 is in a removal process, I also dropped PyQt4 from the ebuild.
Comment 1 Samuel Bauer 2018-03-20 21:17:41 UTC
It also works with all python3_{4,5}, but package was missing [${PYTHON_USEDEP}] for portage.
Comment 2 Samuel Bauer 2018-03-21 01:35:08 UTC
> When I use python2_7 elogviewer doesn't work
See #589910
Comment 3 Jeroen Roovers gentoo-dev 2018-03-23 06:50:05 UTC
Comment on attachment 524618 [details]
elogviewer-2.7.ebuild

Looks like it was recently changed. 

--- elogviewer-2.7-r1.ebuild    2018-03-21 21:44:15.252623687 +0100
+++ -   2018-03-23 07:49:02.618879606 +0100
@@ -1,9 +1,9 @@
-# Copyright 1999-2018 Gentoo Foundation
+# Copyright 1999-2017 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2

 EAPI=6

-PYTHON_COMPAT=( python{2_7,3_4,3_5} )
+PYTHON_COMPAT=( python{3_4,3_5,3_6} )

 DISABLE_AUTOFORMATTING=true

@@ -22,13 +22,9 @@
 RDEPEND="${PYTHON_DEPS}
        || (
                dev-python/PyQt5[gui,widgets,${PYTHON_USEDEP}]
-               dev-python/PyQt4[${PYTHON_USEDEP},X]
                dev-python/pyside[${PYTHON_USEDEP},X]
        )
-       || (
-               >=sys-apps/portage-2.1[${PYTHON_USEDEP}]
-               sys-apps/portage-mgorny[${PYTHON_USEDEP}]
-       )
+       >=sys-apps/portage-2.1[${PYTHON_USEDEP}]
        $(python_gen_cond_dep 'dev-python/enum34[${PYTHON_USEDEP}]' python2_7)
        !dev-python/PyQt5[-gui]
        !dev-python/PyQt5[-widgets]
Comment 4 Samuel Bauer 2018-03-23 22:04:32 UTC
Created attachment 525142 [details, diff]
elogviewer-2.7-r1.patch

My points were
    mainly adding python3_6 as a single target (PyQt is really slow to compile when there's a bunch of python targets)
    drop PyQt4 support as it would help for qt4 removal process.

Removing python2_7 was just a side effect to ensure not being hurt by #589910 but is not the primary goal of this bug, else I'd rather added a comment there.
However, launching elogviewer-2.7-r1 (the new version) with python2_7 as single target still fails with PyQt5. I'm not sure about PyQt4.

Attached patch is valid for current in tree elogviewer.
Runs fine when using python3_6 as single target.
Doesn't break because of PyQt5/python2_7, conditional about this case are quite
Removes conditional about portage being >=2.1, as all in tree version of portage are.
The current in tree version is a good step as it adds [${PYTHON_USEDEP}] for multiple portage versions.