Bug 648796

Summary:	sys-auth/yubico-piv-tool-1.4.4 with >=dev-libs/openssl-1.1.0 - yubico-piv-tool.c:237:10: error: dereferencing pointer to incomplete type ‘RSA {aka struct rsa_st}’
Product:	Gentoo Linux	Reporter:	Quentin Minster <quentin>
Component:	Current packages	Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status:	RESOLVED FIXED
Severity:	normal	CC:	quentin
Priority:	Normal	Keywords:	PATCH
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	592438
Attachments:	build.log yubico-piv-tool-1.5.0-openssl-1.1.0-compat.patch

Description Quentin Minster 2018-02-26 00:58:30 UTC

Created attachment 521052 [details]
build.log

sys-auth/yubico-piv-tool-1.4.4 fails to build with >=dev-libs/openssl-1.1.0, with errors regarding dereferencing pointers to incomplete types, and several warnings about using undeclared functions.

This is due to changes in OpenSSL 1.1.0: internal structures are now opaque, and a lot of functions were deprecated/removed.

Upstream has a new version (1.5.0, see [0]) with some fixes for OpenSSL 1.1.0.
However a simple version bump is not enough, there are still calls to undeclared functions and an undefined symbol, so the build still fails.

I'm attaching below a patch against yubico-piv-tool-1.5.0 that restores compatibility with Gentoo's OpenSSL 1.1.0 (sent upstream, see [1]).


[0]: https://github.com/Yubico/yubico-piv-tool/releases
[1]: https://github.com/Yubico/yubico-piv-tool/pull/141

Comment 1 Quentin Minster 2018-02-26 01:00:43 UTC

Created attachment 521054 [details, diff]
yubico-piv-tool-1.5.0-openssl-1.1.0-compat.patch

Comment 2 Quentin Minster 2018-03-06 01:35:15 UTC

Upstream merged the PR (but there hasn't been any new release yet).

Comment 3 Larry the Git Cow gentoo-dev

2018-03-06 11:23:01 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bce09dab8931afbb372738f1d2c3eca91a727c4f

commit bce09dab8931afbb372738f1d2c3eca91a727c4f
Author:     Michael Palimaka <kensington@gentoo.org>
AuthorDate: 2018-03-06 11:22:22 +0000
Commit:     Michael Palimaka <kensington@gentoo.org>
CommitDate: 2018-03-06 11:22:45 +0000

    sys-auth/yubico-piv-tool: version bump 1.5.0
    
    Includes a backported patch from upstream solving build failure with openssl-1.1.
    
    Closes: https://bugs.gentoo.org/648796
    Package-Manager: Portage-2.3.19, Repoman-2.3.6

 sys-auth/yubico-piv-tool/Manifest                  |   1 +
 .../files/yubico-piv-tool-1.5.0-openssl110.patch   | 170 +++++++++++++++++++++
 .../yubico-piv-tool/yubico-piv-tool-1.5.0.ebuild   |  50 ++++++
 3 files changed, 221 insertions(+)